Update ERC-6909: Move to Review #146
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
File
|
19 tasks
SamWilsn
reviewed
Dec 12, 2023
Contributor
SamWilsn
left a comment
SamWilsn
left a comment
There was a problem hiding this comment.
- Your abstract is a bit too terse. It should include a high-level technical description of how it solves the problem. In this case, maybe you could include a few sentences describing what it removes/adds compared to ERC-1155?
- The interface ID shouldn't be in the rationale section. It belongs in the Specification section.
- Same goes for the metadata extension. Since you're introducing new functionality, and not just explaining the reasoning behind your specification, it has to go in the specification section.
…nto jtriley-eth/to-review
Contributor
Author
|
diff isn't showing bc i merged a different branch into main first, but recommended fixes are done |
17 tasks
SamWilsn
reviewed
Jan 9, 2024
Contributor
SamWilsn
left a comment
SamWilsn
left a comment
There was a problem hiding this comment.
You have a "SHOULD NOT" and a "MAY" requirement in your rationale section. All requirements should be in the specification section.
|
There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review. |
21 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.