-
Notifications
You must be signed in to change notification settings - Fork 6k
Add gas limit increase EIP #9678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
eip-xxxx.md
Outdated
| title: Gas Limit Testing | ||
| description: Test the gas limit up to 150M and recommend a new value for Fusaka | ||
| author: Sophia Gold (@sophia-gold), Parithosh Jayanthi (@parithoshj), Toni Wahrstätter (@nerolation), Carl Beekhuizen (@CarlBeek), Ansgar Dietrichs (@adietrichs), Dankrad Feist (@dankrad), Alex Stokes (@ralexstokes), Matt Garnett (@lightclient), Josh Rudolph (@jrudolph) | ||
| discussions-to: https://ethereum-magicians.org/t/your-discussion-thread |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This link — https://ethereum-magicians.org/t/your-discussion-thread — leads to this: Oops! That page doesn’t exist or is private.
Your link should look more like this: https://ethereum-magicians.org/t/eip-7891-hierarchical-nfts-with-splitting-and-merging/22986
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
eip-xxxx.md
Outdated
|
|
||
| ## Motivation | ||
|
|
||
| There is currently great interest in scaling L1 execution. This can likely be done to some extent without implementing any new features. However, we expect to find bugs in clients at higher gas limits than currently used on mainnet. This will require time from client developers both to test and to fix any bugs that arise, time that could have been spent developing and testing new features, therefore it makes sense to include as an EIP in a hard fork to commit to this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To have stronger motivation, there are still some missing requirements for this section:
- Clearly state the current gas limit and its technical limitations
- Explain the specific problems users and developers face due to these limitations
- Provide context for why this change matters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is sufficient motivation and that expanding it to include "why performance matters" would be a negative signal to the community.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If so, then it shouldn't be under "motivation". It's circularly/farcically written currently.
The motivation is that people care.
If you really think it's a net negative signal which you're determined to avoid, just maybe don't pretend to have a "Motivation" section? And let people judge it as an EIP on that basis.
eip-xxxx.md
Outdated
| ## Specification | ||
|
|
||
| Devnets will be stood up with nodes running all combinations of EL and CL clients in order to test if a gas limit of 60M is safe. Synthetic transactions will be created until blocks are full, and network and node health monitored. If bugs are discovered, client teams will patch them and then start the process again. If everything looks good, the gas limit will be increased incrementally until we have a devnet running smoothly with full blocks at a gas limit of 150M. | ||
|
|
||
| As part of the Fusaka release cycle, client teams will reach consensus on a gas limit validated to be safe through this testing process and test it first on all testnets before adding it to default configs for mainnet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is describing a testing process and future actions, not the actual technical specification of what's being changed. The Specification section should focus only on "what" the change does, specification should define parameters, functions, and behaviors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved this to Rationale and added a more concrete Specification
eip-xxxx.md
Outdated
| --- | ||
| eip: xxxx | ||
| title: Gas Limit Testing | ||
| description: Test the gas limit up to 150M and recommend a new value for Fusaka |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Purely from the title and description (it'll be a bit before I can properly review), this is written more like a project proposal than an EIP.
You should write the recommended technical change with a placeholder, so something like "Increase the block gas limit to Y" in the draft. Then after you do the research, replace the placeholder with the value you determine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
d24fa17 to
d6a855b
Compare
eip-xxxx.md
Outdated
| author: Sophia Gold (@sophia-gold), Parithosh Jayanthi (@parithoshj), Toni Wahrstätter (@nerolation), Carl Beekhuizen (@CarlBeek), Ansgar Dietrichs (@adietrichs), Dankrad Feist (@dankrad), Alex Stokes (@ralexstokes), Josh Rudolph (@jrudolph), Giulio Rebuffo (@Giulio2002), Storm Slivkoff (@sslivkoff) | ||
| discussions-to: https://ethereum-magicians.org/t/your-discussion-thread | ||
| status: Draft | ||
| type: Core |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| type: Core | |
| type: Informational |
Since defaults are not part of the protocol, but client configurations, this would need to be informational like EIP-7840.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
f969e3f to
f47fef3
Compare
|
The commit f47fef3 (as a parent of 333b01c) contains errors. |
eip-xxxx.md
Outdated
| @@ -0,0 +1,40 @@ | |||
| --- | |||
| eip: xxxx | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| eip: xxxx | |
| eip: 7935 |
please also update the file name!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
f47fef3 to
82037e1
Compare
eip-7935.md
Outdated
| title: Set default gas limit to XX0M | ||
| description: Recommend a new gas limit value for Fusaka and update execution layer client default configs | ||
| author: Sophia Gold (@sophia-gold), Parithosh Jayanthi (@parithoshj), Toni Wahrstätter (@nerolation), Carl Beekhuizen (@CarlBeek), Ansgar Dietrichs (@adietrichs), Dankrad Feist (@dankrad), Alex Stokes (@ralexstokes), Josh Rudolph (@jrudolph), Giulio Rebuffo (@Giulio2002), Storm Slivkoff (@sslivkoff) | ||
| discussions-to: https://ethereum-magicians.org/t/eip-xxxx-set-default-gas-limit-to-xx0m/23789 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove xxxx from the url (so fix the url as well)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
eip-7935.md
Outdated
|
|
||
| ## Motivation | ||
|
|
||
| There is currently great interest in scaling L1 execution. This can likely be done to some extent without implementing any new features. However, it requires guidance from EL devs as we expect to find bugs in clients at higher gas limits than currently used on mainnet. This will require time from client developers both to test and to fix any bugs that arise, time that could have been spent developing and testing new features, therefore it makes sense to include as an EIP in a hard fork to commit to this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| There is currently great interest in scaling L1 execution. This can likely be done to some extent without implementing any new features. However, it requires guidance from EL devs as we expect to find bugs in clients at higher gas limits than currently used on mainnet. This will require time from client developers both to test and to fix any bugs that arise, time that could have been spent developing and testing new features, therefore it makes sense to include as an EIP in a hard fork to commit to this. | |
| There is currently great interest in scaling L1 execution. This can likely be done to some extent without implementing any new features. However, it requires guidance from EL devs as we expect to find bugs in clients at higher gas limits than currently used on mainnet. This will require time from client developers both to test and to fix any bugs that arise, therefore it makes sense to include as an EIP in a hard fork to commit to this. |
that line seems like arguing against the EIP to not spend time on this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed
eip-7935.md
Outdated
|
|
||
| ## Abstract | ||
|
|
||
| The gas limit on mainnet is currently 36M. This should be significantly increased by the time Fusaka is released by execution layer clients updating their default configurations. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| The gas limit on mainnet is currently 36M. This should be significantly increased by the time Fusaka is released by execution layer clients updating their default configurations. | |
| The gas limit on mainnet is currently 36M. This should be significantly increased to XX0M by the time Fusaka is released by execution layer clients updating their default configurations. |
also add a html marker <--TODO--> for bots to flag this if you try moving post draft without filling this limit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
eip-7935.md
Outdated
|
|
||
| ## Specification | ||
|
|
||
| Execution layer clients have different configuration formats. They should all update the gas limit value generated in their default configurations to the one specified in this EIP. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Execution layer clients have different configuration formats. They should all update the gas limit value generated in their default configurations to the one specified in this EIP. | |
| Execution layer clients have different configuration formats. They should all update the gas limit value in their default configurations to XX0M. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
eip-7935.md
Outdated
|
|
||
| ## Rationale | ||
|
|
||
| Devnets will be stood up with nodes running all combinations of EL and CL clients in order to test if a gas limit of 60M is safe. Synthetic transactions will be created until blocks are full, and network and node health monitored. If bugs are discovered, client teams will patch them and then start the process again. If everything looks good, the gas limit will be increased incrementally. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is not rationale but testing details
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved to Security Considerations
82037e1 to
6ade992
Compare
6ade992 to
8c88bf1
Compare
noelportillo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good thing because I'm going back
EIP to recommend a new gas limit by the time Fusaka is released and update EL default configs.