Skip to content

Conversation

@Sophia-Gold
Copy link
Contributor

@Sophia-Gold Sophia-Gold commented Apr 23, 2025

EIP to recommend a new gas limit by the time Fusaka is released and update EL default configs.

@Sophia-Gold Sophia-Gold requested a review from eth-bot as a code owner April 23, 2025 04:03
@github-actions github-actions bot added c-new Creates a brand new proposal s-draft This EIP is a Draft labels Apr 23, 2025
@eth-bot
Copy link
Collaborator

eth-bot commented Apr 23, 2025

File eip-7935.md

Requires 1 more reviewers from @g11tech, @SamWilsn, @xinbenlv

@eth-bot eth-bot added the e-consensus Waiting on editor consensus label Apr 23, 2025
@github-actions github-actions bot added the w-ci Waiting on CI to pass label Apr 23, 2025
eip-xxxx.md Outdated
title: Gas Limit Testing
description: Test the gas limit up to 150M and recommend a new value for Fusaka
author: Sophia Gold (@sophia-gold), Parithosh Jayanthi (@parithoshj), Toni Wahrstätter (@nerolation), Carl Beekhuizen (@CarlBeek), Ansgar Dietrichs (@adietrichs), Dankrad Feist (@dankrad), Alex Stokes (@ralexstokes), Matt Garnett (@lightclient), Josh Rudolph (@jrudolph)
discussions-to: https://ethereum-magicians.org/t/your-discussion-thread

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link — https://ethereum-magicians.org/t/your-discussion-thread — leads to this: Oops! That page doesn’t exist or is private.

Your link should look more like this: https://ethereum-magicians.org/t/eip-7891-hierarchical-nfts-with-splitting-and-merging/22986

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

eip-xxxx.md Outdated

## Motivation

There is currently great interest in scaling L1 execution. This can likely be done to some extent without implementing any new features. However, we expect to find bugs in clients at higher gas limits than currently used on mainnet. This will require time from client developers both to test and to fix any bugs that arise, time that could have been spent developing and testing new features, therefore it makes sense to include as an EIP in a hard fork to commit to this.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To have stronger motivation, there are still some missing requirements for this section:

  • Clearly state the current gas limit and its technical limitations
  • Explain the specific problems users and developers face due to these limitations
  • Provide context for why this change matters

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is sufficient motivation and that expanding it to include "why performance matters" would be a negative signal to the community.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If so, then it shouldn't be under "motivation". It's circularly/farcically written currently.

The motivation is that people care.

If you really think it's a net negative signal which you're determined to avoid, just maybe don't pretend to have a "Motivation" section? And let people judge it as an EIP on that basis.

eip-xxxx.md Outdated
Comment on lines 20 to 28
## Specification

Devnets will be stood up with nodes running all combinations of EL and CL clients in order to test if a gas limit of 60M is safe. Synthetic transactions will be created until blocks are full, and network and node health monitored. If bugs are discovered, client teams will patch them and then start the process again. If everything looks good, the gas limit will be increased incrementally until we have a devnet running smoothly with full blocks at a gas limit of 150M.

As part of the Fusaka release cycle, client teams will reach consensus on a gas limit validated to be safe through this testing process and test it first on all testnets before adding it to default configs for mainnet.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is describing a testing process and future actions, not the actual technical specification of what's being changed. The Specification section should focus only on "what" the change does, specification should define parameters, functions, and behaviors.

Copy link
Contributor Author

@Sophia-Gold Sophia-Gold Apr 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved this to Rationale and added a more concrete Specification

eip-xxxx.md Outdated
---
eip: xxxx
title: Gas Limit Testing
description: Test the gas limit up to 150M and recommend a new value for Fusaka
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Purely from the title and description (it'll be a bit before I can properly review), this is written more like a project proposal than an EIP.

You should write the recommended technical change with a placeholder, so something like "Increase the block gas limit to Y" in the draft. Then after you do the research, replace the placeholder with the value you determine.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@Sophia-Gold Sophia-Gold changed the title Add gas limit testing EIP Add gas limit increase EIP Apr 23, 2025
eip-xxxx.md Outdated
author: Sophia Gold (@sophia-gold), Parithosh Jayanthi (@parithoshj), Toni Wahrstätter (@nerolation), Carl Beekhuizen (@CarlBeek), Ansgar Dietrichs (@adietrichs), Dankrad Feist (@dankrad), Alex Stokes (@ralexstokes), Josh Rudolph (@jrudolph), Giulio Rebuffo (@Giulio2002), Storm Slivkoff (@sslivkoff)
discussions-to: https://ethereum-magicians.org/t/your-discussion-thread
status: Draft
type: Core
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
type: Core
type: Informational

Since defaults are not part of the protocol, but client configurations, this would need to be informational like EIP-7840.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@Sophia-Gold Sophia-Gold force-pushed the gas-limit-testing branch 3 times, most recently from f969e3f to f47fef3 Compare April 23, 2025 17:26
@github-actions
Copy link

The commit f47fef3 (as a parent of 333b01c) contains errors.
Please inspect the Run Summary for details.

eip-xxxx.md Outdated
@@ -0,0 +1,40 @@
---
eip: xxxx
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
eip: xxxx
eip: 7935

please also update the file name!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@github-actions github-actions bot removed the w-ci Waiting on CI to pass label Apr 23, 2025
lightclient
lightclient previously approved these changes Apr 24, 2025
eip-7935.md Outdated
title: Set default gas limit to XX0M
description: Recommend a new gas limit value for Fusaka and update execution layer client default configs
author: Sophia Gold (@sophia-gold), Parithosh Jayanthi (@parithoshj), Toni Wahrstätter (@nerolation), Carl Beekhuizen (@CarlBeek), Ansgar Dietrichs (@adietrichs), Dankrad Feist (@dankrad), Alex Stokes (@ralexstokes), Josh Rudolph (@jrudolph), Giulio Rebuffo (@Giulio2002), Storm Slivkoff (@sslivkoff)
discussions-to: https://ethereum-magicians.org/t/eip-xxxx-set-default-gas-limit-to-xx0m/23789
Copy link
Contributor

@g11tech g11tech Apr 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove xxxx from the url (so fix the url as well)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

eip-7935.md Outdated

## Motivation

There is currently great interest in scaling L1 execution. This can likely be done to some extent without implementing any new features. However, it requires guidance from EL devs as we expect to find bugs in clients at higher gas limits than currently used on mainnet. This will require time from client developers both to test and to fix any bugs that arise, time that could have been spent developing and testing new features, therefore it makes sense to include as an EIP in a hard fork to commit to this.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
There is currently great interest in scaling L1 execution. This can likely be done to some extent without implementing any new features. However, it requires guidance from EL devs as we expect to find bugs in clients at higher gas limits than currently used on mainnet. This will require time from client developers both to test and to fix any bugs that arise, time that could have been spent developing and testing new features, therefore it makes sense to include as an EIP in a hard fork to commit to this.
There is currently great interest in scaling L1 execution. This can likely be done to some extent without implementing any new features. However, it requires guidance from EL devs as we expect to find bugs in clients at higher gas limits than currently used on mainnet. This will require time from client developers both to test and to fix any bugs that arise, therefore it makes sense to include as an EIP in a hard fork to commit to this.

that line seems like arguing against the EIP to not spend time on this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed

eip-7935.md Outdated

## Abstract

The gas limit on mainnet is currently 36M. This should be significantly increased by the time Fusaka is released by execution layer clients updating their default configurations.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The gas limit on mainnet is currently 36M. This should be significantly increased by the time Fusaka is released by execution layer clients updating their default configurations.
The gas limit on mainnet is currently 36M. This should be significantly increased to XX0M by the time Fusaka is released by execution layer clients updating their default configurations.

also add a html marker <--TODO--> for bots to flag this if you try moving post draft without filling this limit

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

eip-7935.md Outdated

## Specification

Execution layer clients have different configuration formats. They should all update the gas limit value generated in their default configurations to the one specified in this EIP.
Copy link
Contributor

@g11tech g11tech Apr 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Execution layer clients have different configuration formats. They should all update the gas limit value generated in their default configurations to the one specified in this EIP.
Execution layer clients have different configuration formats. They should all update the gas limit value in their default configurations to XX0M.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

eip-7935.md Outdated

## Rationale

Devnets will be stood up with nodes running all combinations of EL and CL clients in order to test if a gas limit of 60M is safe. Synthetic transactions will be created until blocks are full, and network and node health monitored. If bugs are discovered, client teams will patch them and then start the process again. If everything looks good, the gas limit will be increased incrementally.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not rationale but testing details

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved to Security Considerations

@Sophia-Gold Sophia-Gold force-pushed the gas-limit-testing branch from 6ade992 to 8c88bf1 Compare May 1, 2025 20:23
@lightclient lightclient merged commit 636a227 into ethereum:master May 2, 2025
12 of 15 checks passed
Copy link

@noelportillo noelportillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good thing because I'm going back

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c-new Creates a brand new proposal e-consensus Waiting on editor consensus s-draft This EIP is a Draft t-informational

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants