Update EIP-7691: clarify that all 3 EL constants change in Prague #9243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
c-update
Collaborator
File
|
|
The commit 28cb3af (as a parent of 42de71c) contains errors. |
nerolation
reviewed
Jan 15, 2025
Contributor
nerolation
left a comment
nerolation
left a comment
There was a problem hiding this comment.
lgtm, waiting for 1 more review.
Contributor
Author
|
Validation complains about the presence of reference to the peerDAS EIP-7594, which is now stagnant. I think it is fine to drop the specific EIP reference, but I defer to the authors. |
31 tasks
13 tasks
|
There has been no activity on this issue for six months. It will be closed in 7 days if there is no new activity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise the doc would say:
while
MAX_BLOB_GAS_PER_BLOCKis given a new value, which threw me off for a second.