interop: supervisor_dependencySet API #684
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emhane
reviewed
Apr 25, 2025
emhane
added
H-interop
tynes
reviewed
May 28, 2025
|
For readers: this PR is not accurate, the format changed last 2 weeks. Will need to update this after other higher priority work is out of the way. |
protolambda
force-pushed
the
dependency-set-api
branch
from
8a6522b to
9d018c3
Compare
|
Rebased and updated to match ethereum-optimism/optimism#16156 |
sebastianst
approved these changes
Jun 10, 2025
| - `dependencies`: `MAP`: | ||
| - key: `ChainID` | ||
| - value: `ConfigDependency`: `OBJECT`: empty object. This may be extended in the future. | ||
| - `overrideMessageExpiryWindow`: `uint64`: changes the default protocol expiry window time. |
There was a problem hiding this comment.
So this isn't something we only use in tests, but want to have in the specs?
There was a problem hiding this comment.
I already suggested to change it to just be messageExpiryWindow, but there is no support/momentum on all the usages of this config code to change it.
emhane
reviewed
Jun 17, 2025
Comment on lines
+126
to
+127
| Decimal-encoded string, variable length up to 256 bits. | ||
| This supports decoding of hex-encoded values when prefixed with `0x`. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See ethereum-optimism/optimism#15048