Skip to content

Conversation

teddyknox
Copy link
Contributor

Description

Adds a set of scripts that make it easy to generate specifications for upgrade/proxy update transactions.
Tests

I manually compared the result of this script to previous specifications for upgrade/proxy update transactions, given the same input.

Additional context

Used to generate #672.

@teddyknox teddyknox requested review from a team as code owners April 22, 2025 11:37
@teddyknox teddyknox force-pushed the upgrade-tx-spec-script branch 2 times, most recently from 5d4346b to 9b6e587 Compare April 22, 2025 11:56
@teddyknox teddyknox changed the title Add script for generating upgrade txs Add script for generating upgrade tx specs Apr 22, 2025
@teddyknox teddyknox requested review from tynes and protolambda April 22, 2025 13:54
@teddyknox teddyknox force-pushed the upgrade-tx-spec-script branch from 9b6e587 to d0b3baa Compare April 22, 2025 16:36
@teddyknox teddyknox requested a review from sebastianst April 23, 2025 18:56
@emhane emhane added the H-interop Hardfork: change planned for Interop upgrade label Apr 24, 2025
@emhane emhane added the A-meta Area: changes in the contributor workflow and planning label Apr 24, 2025
Copy link
Member

@emhane emhane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we have a workflow for manually dispatching this script in ci pls?

@teddyknox teddyknox force-pushed the upgrade-tx-spec-script branch from d0b3baa to 099875a Compare April 28, 2025 17:08
@teddyknox
Copy link
Contributor Author

@emhane as a test? Or what would be the purpose?

@emhane
Copy link
Member

emhane commented Apr 28, 2025

@emhane as a test? Or what would be the purpose?

for creating new specs when needed and, yes, for not relying on manual test to check its validity

@teddyknox teddyknox force-pushed the upgrade-tx-spec-script branch from 099875a to 3706ac1 Compare April 29, 2025 21:10
@teddyknox teddyknox force-pushed the upgrade-tx-spec-script branch from 3706ac1 to f6ebd7a Compare April 29, 2025 21:18
@teddyknox teddyknox requested a review from sebastianst April 30, 2025 12:42
@tynes
Copy link
Contributor

tynes commented Jul 8, 2025

I would love to merge this but ideally it uses uv instead of pip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-meta Area: changes in the contributor workflow and planning H-interop Hardfork: change planned for Interop upgrade
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants