fix(op-alt-da): ensure HTTP response bodies are closed in error cases #17948
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a resource leak in
op-alt-da/daclient.goby ensuring HTTP response bodies are properly closed in all error scenarios.Problem
The
GetInputmethod inDAClientwas not closing HTTP response bodies when returning early due to error status codes (404, non-200). This can lead to:Solution
Moved
defer resp.Body.Close()immediately after theclient.Do(req)call to guarantee response body closure in all execution paths, including error cases.