Skip to content

Final topping #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Final topping #43

wants to merge 3 commits into from

Conversation

enothum
Copy link
Collaborator

@enothum enothum commented Feb 21, 2025

PR contains the a couple of last topping changes:

  • A small fix when running both Delta and LoRA concurrently, in the embedding and logits layers code, the delta indices needed to be recovered to avoid index out of bounds errors
  • the final plotting and benchmarking code

@enothum enothum requested a review from xzyaoi February 21, 2025 20:49
@xzyaoi xzyaoi changed the base branch from main to dev February 23, 2025 20:26
Base automatically changed from dev to main May 27, 2025 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xzyaoi xzyaoi Awaiting requested review from xzyaoi

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@enothum