Models/qwen2 vl #24
Merged
Models/qwen2 vl #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Copilot reviewed 22 out of 37 changed files in this pull request and generated 2 comments.
Files not reviewed (15)
- scratchpad/managers/tokenizer.py: Evaluated as low risk
- scratchpad/nn/layers/activation.py: Evaluated as low risk
- scratchpad/nn/models/llama_moe.py: Evaluated as low risk
- scratchpad/nn/models/llama.py: Evaluated as low risk
- scratchpad/model_executor/model_runner.py: Evaluated as low risk
- scratchpad/nn/attention/radix_attention.py: Evaluated as low risk
- scratchpad/nn/models/init.py: Evaluated as low risk
- scratchpad/model_executor/cuda_graph_runner.py: Evaluated as low risk
- scratchpad/nn/layers/logits_processor.py: Evaluated as low risk
- scratchpad/nn/attention/backend.py: Evaluated as low risk
- scratchpad/nn/layers/rotary_embedding.py: Evaluated as low risk
- scratchpad/managers/structs.py: Evaluated as low risk
- scratchpad/memory/chunk_cache.py: Evaluated as low risk
- scratchpad/memory/radix_cache.py: Evaluated as low risk
- scratchpad/memory/pool.py: Evaluated as low risk
Comments suppressed due to low confidence (3)
scratchpad/model_executor/forward_info.py:60
- [nitpick] Consider renaming
is_cuda_graphtois_cuda_graph_modefor clarity.
def is_cuda_graph(self):
scratchpad/managers/detokenizer.py:157
- Ensure that the change from
finished_reasontofinished_reasonsis consistently applied across the codebase.
if recv_obj.finished_reasons[i] is None:
scratchpad/config/utils.py:108
- The variable sliding_window_len_min is used without being defined. It should be defined or assigned a value before being used.
sliding_window_len_min = get_min_sliding_window(sliding_window_len)
|
|
||
| return pixel_values, image_hash, image.size, image_grid_thws | ||
| except Exception: | ||
| logger.error("Exception in TokenizerManager:\n" + get_exception_traceback()) |
There was a problem hiding this comment.
Consider re-raising exceptions after logging them to avoid hiding errors.
Suggested change
| logger.error("Exception in TokenizerManager:\n" + get_exception_traceback()) | |
| raise |
|
|
||
| self.decode_status = LimitedCapacityDict() | ||
|
|
||
| def trim_matched_stop( |
There was a problem hiding this comment.
The trim_matched_stop function should handle cases where matched is a list of strings or integers.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #22