-
Couldn't load subscription status.
- Fork 15
Simplify the the specification of allocation details for matrices. #1343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
cscs-ci run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The main comment I have is about the possible semantic confusion we might have between MatrixAllocation and AllocationType. I'm not referring to the naming of the classes, but more on the current names of the functions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only minor nits, this looks nice overall.
|
As it was spread on multiple conversation I answer here. @albestro The previous use of the name MatrixAllocation happened to not be a good choice. MatrixAllocation is now used to collect all the useful specs which can modify the way the matrix buffers is allocated. However not all the options have an impact on how the matrix is used. How the leading dimension was picked and (in the future) if the matrix is allocated on demand don't have any effect on how the matrix is used. Regarding the |
Co-authored-by: Alberto Invernizzi <[email protected]> Co-authored-by: Mikael Simberg <[email protected]>
Co-authored-by: Alberto Invernizzi <[email protected]>
bdd0637 to
8a0e533
Compare
|
cscs-ci run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Renaming looks as discussed, thanks @rasolca!
| inline std::string copy_to_lower(const std::string& str) { | ||
| std::string s(str); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very minor consideration
| inline std::string copy_to_lower(const std::string& str) { | |
| std::string s(str); | |
| inline std::string copy_to_lower(std::string s) { |
A tune parameter for the default AllocationLayout has been added too.