-
Notifications
You must be signed in to change notification settings - Fork 10.2k
DONOTMERGE: reproduce #20271 #20503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DONOTMERGE: reproduce #20271 #20503
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fuweid The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@fuweid: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
... and 144 files with indirect coverage changes @@ Coverage Diff @@
## main #20503 +/- ##
==========================================
- Coverage 69.12% 62.71% -6.42%
==========================================
Files 418 405 -13
Lines 34696 33591 -1105
==========================================
- Hits 23985 21065 -2920
- Misses 9310 10966 +1656
- Partials 1401 1560 +159 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
func (ep *EtcdServerProcess) Pause() error { | ||
ep.cfg.lg.Info("Pausing server...", zap.String("name", ep.cfg.Name)) | ||
return ep.proc.Signal(syscall.SIGSTOP) | ||
} | ||
|
||
func (ep *EtcdServerProcess) Resume() error { | ||
ep.cfg.lg.Info("Resuming server...", zap.String("name", ep.cfg.Name)) | ||
return ep.proc.Signal(syscall.SIGCONT) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add them into the interface as well,
etcd/tests/framework/e2e/etcd_process.go
Lines 44 to 62 in 66e4a11
type EtcdProcess interface { | |
EndpointsGRPC() []string | |
EndpointsHTTP() []string | |
EndpointsMetrics() []string | |
Etcdctl(opts ...config.ClientOption) *EtcdctlV3 | |
IsRunning() bool | |
Wait(ctx context.Context) error | |
Start(ctx context.Context) error | |
Restart(ctx context.Context) error | |
Stop() error | |
Close() error | |
Config() *EtcdServerProcessConfig | |
PeerProxy() proxy.Server | |
Failpoints() *BinaryFailpoints | |
LazyFS() *LazyFS | |
Logs() LogsExpect | |
Kill() error | |
} |
REF: #20271
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.