Skip to content

Conversation

fuweid
Copy link
Member

@fuweid fuweid commented Aug 18, 2025

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fuweid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link

@fuweid: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-etcd-verify e8db4b2 link true /test pull-etcd-verify
pull-etcd-e2e-amd64 e8db4b2 link true /test pull-etcd-e2e-amd64

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link

codecov bot commented Aug 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.71%. Comparing base (b55e8ff) to head (e8db4b2).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
Files with missing lines Coverage Δ
server/etcdserver/server.go 79.83% <100.00%> (-2.96%) ⬇️

... and 144 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #20503      +/-   ##
==========================================
- Coverage   69.12%   62.71%   -6.42%     
==========================================
  Files         418      405      -13     
  Lines       34696    33591    -1105     
==========================================
- Hits        23985    21065    -2920     
- Misses       9310    10966    +1656     
- Partials     1401     1560     +159     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b55e8ff...e8db4b2. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment on lines +278 to +286
func (ep *EtcdServerProcess) Pause() error {
ep.cfg.lg.Info("Pausing server...", zap.String("name", ep.cfg.Name))
return ep.proc.Signal(syscall.SIGSTOP)
}

func (ep *EtcdServerProcess) Resume() error {
ep.cfg.lg.Info("Resuming server...", zap.String("name", ep.cfg.Name))
return ep.proc.Signal(syscall.SIGCONT)
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add them into the interface as well,

type EtcdProcess interface {
EndpointsGRPC() []string
EndpointsHTTP() []string
EndpointsMetrics() []string
Etcdctl(opts ...config.ClientOption) *EtcdctlV3
IsRunning() bool
Wait(ctx context.Context) error
Start(ctx context.Context) error
Restart(ctx context.Context) error
Stop() error
Close() error
Config() *EtcdServerProcessConfig
PeerProxy() proxy.Server
Failpoints() *BinaryFailpoints
LazyFS() *LazyFS
Logs() LogsExpect
Kill() error
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants