-
Notifications
You must be signed in to change notification settings - Fork 10.2k
Draft implementation of testing cache in robustness tests #20354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@serathius: GitHub didn't allow me to request PR reviews from the following users: apullo777. Note that only etcd-io members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: serathius The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted filessee 34 files with indirect coverage changes @@ Coverage Diff @@
## main #20354 +/- ##
==========================================
+ Coverage 68.86% 68.91% +0.04%
==========================================
Files 418 417 -1
Lines 34692 34644 -48
==========================================
- Hits 23891 23874 -17
+ Misses 9416 9359 -57
- Partials 1385 1411 +26 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
24d5202
to
684557d
Compare
Extracted #20355 |
684557d
to
ba2e0d8
Compare
654c831
to
6488548
Compare
6488548
to
117e71d
Compare
/retest |
edc9ecf
to
ad5c5d5
Compare
ad5c5d5
to
a22251d
Compare
a22251d
to
157d75c
Compare
…tes finish and max revision is provided Signed-off-by: Marek Siarkowicz <[email protected]>
Signed-off-by: Marek Siarkowicz <[email protected]>
157d75c
to
7992960
Compare
For now just to show how the integration could look like, a more permanent solution would have a separate test scenario.
I think the tests deadlocks because cache doesn't support progress notifications.
/cc @apullo777 @MadhavJivrajani