Skip to content

Conversation

serathius
Copy link
Member

For now just to show how the integration could look like, a more permanent solution would have a separate test scenario.

I think the tests deadlocks because cache doesn't support progress notifications.

/cc @apullo777 @MadhavJivrajani

@k8s-ci-robot
Copy link

@serathius: GitHub didn't allow me to request PR reviews from the following users: apullo777.

Note that only etcd-io members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

For now just to show how the integration could look like, a more permanent solution would have a separate test scenario.

I think the tests deadlocks because cache doesn't support progress notifications.

/cc @apullo777 @MadhavJivrajani

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Jul 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.91%. Comparing base (6fca19f) to head (7992960).

Additional details and impacted files

see 34 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #20354      +/-   ##
==========================================
+ Coverage   68.86%   68.91%   +0.04%     
==========================================
  Files         418      417       -1     
  Lines       34692    34644      -48     
==========================================
- Hits        23891    23874      -17     
+ Misses       9416     9359      -57     
- Partials     1385     1411      +26     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6fca19f...7992960. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@serathius
Copy link
Member Author

Extracted #20355

@serathius serathius force-pushed the robustness-cache branch 4 times, most recently from 654c831 to 6488548 Compare August 14, 2025 09:27
@serathius
Copy link
Member Author

/retest

…tes finish and max revision is provided

Signed-off-by: Marek Siarkowicz <[email protected]>
Signed-off-by: Marek Siarkowicz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants