[release-3.5] Remove integration_extra from integration tests #20198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/retest |
|
/cc @ahrtr |
serathius
reviewed
Jun 20, 2025
| function integration_extra { | ||
| if [ -z "${PKG}" ] ; then | ||
| run_for_module "." go_test "./contrib/raftexample" "keep_going" : -timeout="${TIMEOUT:-5m}" "${RUN_ARG[@]}" "${COMMON_TEST_FLAGS[@]}" "$@" || return $? | ||
| run_for_module "tests" go_test "./integration/v2store/..." "keep_going" : -tags v2v3 -timeout="${TIMEOUT:-5m}" "${RUN_ARG[@]}" "${COMMON_TEST_FLAGS[@]}" "$@" || return $? |
There was a problem hiding this comment.
#14881 removed "./contrib/raftexample" but kept "./integration/v2store/..."
There was a problem hiding this comment.
So, should we keep ./integration/v2store/...?
ahrtr
approved these changes
Jun 22, 2025
Signed-off-by: joshjms <[email protected]>
joshjms
force-pushed
the
release-3.5-remove-integration-extra
branch
from
4659667 to
018f370
Compare
ivanvc
approved these changes
Jun 23, 2025
serathius
approved these changes
Jun 24, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, ivanvc, joshjms, serathius The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
Link to kubernetes/test-infra#32754. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #20168 (comment)
/cc @ivanvc @serathius
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.