Skip to content

fix: test-release checks #19848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 1, 2025

Conversation

joshjms
Copy link
Member

@joshjms joshjms commented Apr 30, 2025

Address reviews in etcd-io#19815

Signed-off-by: joshjms <[email protected]>
Copy link

codecov bot commented May 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.01%. Comparing base (64cd6b6) to head (c940bf5).
Report is 38 commits behind head on main.

Additional details and impacted files

see 23 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19848      +/-   ##
==========================================
+ Coverage   68.81%   69.01%   +0.19%     
==========================================
  Files         424      424              
  Lines       35862    35862              
==========================================
+ Hits        24680    24750      +70     
+ Misses       9756     9699      -57     
+ Partials     1426     1413      -13     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64cd6b6...c940bf5. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@joshjms
Copy link
Member Author

joshjms commented May 1, 2025

/retest

@joshjms
Copy link
Member Author

joshjms commented May 1, 2025

/ok-to-test

@ivanvc
Copy link
Member

ivanvc commented May 1, 2025

/ok-to-test

@joshjms, please open a pull request in k/org, adding yourself to the members team. So you don't need to /ok-to-test yourself on your own pull requests 😅
https://github.com/kubernetes/org/blob/ace2cfda01fc63f84fa1f61138eb22125ca2b1ed/config/etcd-io/sig-etcd/teams.yaml#L126

Copy link
Member

@ivanvc ivanvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on green. Thanks, @joshjms.

@joshjms
Copy link
Member Author

joshjms commented May 1, 2025

Oh I am already a member, I'm just testing the command (it's my first time using it lol) 😂

@joshjms
Copy link
Member Author

joshjms commented May 1, 2025

/retest

1 similar comment
@joshjms
Copy link
Member Author

joshjms commented May 1, 2025

/retest

Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks @joshjms

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, ivanvc, jmhbnz, joshjms

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr merged commit 07c6977 into etcd-io:main May 1, 2025
33 checks passed
@ivanvc
Copy link
Member

ivanvc commented May 2, 2025

/cherry-pick release-3.6

@k8s-infra-cherrypick-robot

@ivanvc: new pull request created: #19853

In response to this:

/cherry-pick release-3.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

joshjms added a commit to joshjms/etcd that referenced this pull request May 3, 2025
Address reviews in etcd-io#19815

This is a cherrypick of c940bf5
PR: etcd-io#19848

Signed-off-by: joshjms <[email protected]>
joshjms added a commit to joshjms/etcd that referenced this pull request May 3, 2025
Address reviews in etcd-io#19815

This is a cherrypick of c940bf5
PR: etcd-io#19848

Signed-off-by: joshjms <[email protected]>
joshjms added a commit to joshjms/etcd that referenced this pull request May 3, 2025
Address reviews in etcd-io#19815

This is a cherrypick of c940bf5
PR: etcd-io#19848

Signed-off-by: joshjms <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

6 participants