-
Notifications
You must be signed in to change notification settings - Fork 10.1k
fix: test-release checks #19848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: test-release checks #19848
Conversation
Address reviews in etcd-io#19815 Signed-off-by: joshjms <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted filessee 23 files with indirect coverage changes @@ Coverage Diff @@
## main #19848 +/- ##
==========================================
+ Coverage 68.81% 69.01% +0.19%
==========================================
Files 424 424
Lines 35862 35862
==========================================
+ Hits 24680 24750 +70
+ Misses 9756 9699 -57
+ Partials 1426 1413 -13 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
/retest |
/ok-to-test |
@joshjms, please open a pull request in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM on green. Thanks, @joshjms.
Oh I am already a member, I'm just testing the command (it's my first time using it lol) 😂 |
/retest |
1 similar comment
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Thanks @joshjms
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, ivanvc, jmhbnz, joshjms The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-3.6 |
@ivanvc: new pull request created: #19853 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Address reviews in etcd-io#19815 This is a cherrypick of c940bf5 PR: etcd-io#19848 Signed-off-by: joshjms <[email protected]>
Address reviews in etcd-io#19815 This is a cherrypick of c940bf5 PR: etcd-io#19848 Signed-off-by: joshjms <[email protected]>
Address reviews in etcd-io#19815 This is a cherrypick of c940bf5 PR: etcd-io#19848 Signed-off-by: joshjms <[email protected]>
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.
Address reviews in #19815
/cc @ivanvc @jmhbnz