Skip to content

Conversation

gojimmypi
Copy link
Contributor

@gojimmypi gojimmypi commented Oct 1, 2025

Description

This is the fifth in a series of pull requests to improve wolfSSL integration with the ESP-IDF as proposed in #16145

As there are multiple changes there, it was suggested that I break the update into smaller pieces.

This PR updates the requirements for wolfSSL in the components/esp-tls/esp_tls.c and components/esp-tls/esp_tls.h

Related

See:

Testing

The fully-implemented update is on my wolfssl-dev branch. I've been testing with this esp_http_client_example.

See also the published wolfSSL Managed component that already includes the Certificate Bundle feature introduced in wolfSSL/wolfssl#7936


Checklist

Before submitting a Pull Request, please ensure the following:

  • 🚨 This PR does not introduce breaking changes.
  • All CI checks (GH Actions) pass.
  • Documentation is updated as needed.
  • Tests are updated or added as necessary.
  • Code is well-commented, especially in complex areas.
  • Git history is clean — commits are squashed to the minimum necessary.

Note

Add safety checks and debug logging, validate tls before connecting, and make esp_tls_server_session_delete return int under wolfSSL via conditional prototypes/impl.

  • esp-tls core:
    • Safety: esp_tls_conn_read now validates data; esp_tls_low_level_conn validates tls and returns -1 on NULL.
    • Debug: Added log before create_ssl_handle with target hostname:port.
  • wolfSSL integration:
    • API: esp_tls_server_session_delete returns int when CONFIG_ESP_TLS_USING_WOLFSSL, void otherwise; updated declarations/definitions accordingly.
    • Define ESP_TLS_HAS_WOLFSSL in components/esp-tls/esp_tls.h for supported wolfSSL versions.

Written by Cursor Bugbot for commit 31496c1. This will update automatically on new commits. Configure here.

Copy link

github-actions bot commented Oct 1, 2025

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello gojimmypi, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.

This GitHub project is public mirror of our internal git repository

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved, we synchronize it into our internal git repository.
4. In the internal git repository we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
5. If the change is approved and passes the tests it is merged into the default branch.
5. On next sync from the internal git repository merged change will appear in this public GitHub repository.

Generated by 🚫 dangerJS against 31496c1

@github-actions github-actions bot changed the title feat(esp-tls): Update esp_tls for improved wolfssl support feat(esp-tls): Update esp_tls for improved wolfssl support (IDFGH-16561) Oct 1, 2025
@espressif-bot espressif-bot added the Status: Opened Issue is new label Oct 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Opened Issue is new
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants