Skip to content

Conversation

TheSciBoy
Copy link

@TheSciBoy TheSciBoy commented Aug 14, 2025

Description

Includes changes in MQTT and MBED-TLS to support setting the I2C address of a secure element during runtime. This is required for systems where it cannot be determined at compile-time which secure element (ATEC608A) is installed on the hardware, something which may be, for example, configured during production instead.

This way, a new option is added in the configuration to instead of selecting which secure element is used in hardware, a runtime selection item is chosen instead. Checks are added that require the I2C address to be actively set (default is 0, which is not a valid address).

Related

None

Testing

Testing has only been performed on our own proprietary hardware, with the libraries for our own purposes activated. We build locally in a clean docker environment.

Checklist

Before submitting a Pull Request, please ensure the following:

  • [ x] 🚨 This PR does not introduce breaking changes.
  • [ x] All CI checks (GH Actions) pass.
  • Documentation is updated as needed.
  • Tests are updated or added as necessary.
  • [ x] Code is well-commented, especially in complex areas.
  • [ x] Git history is clean — commits are squashed to the minimum necessary.

@CLAassistant
Copy link

CLAassistant commented Aug 14, 2025

CLA assistant check
All committers have signed the CLA.

Copy link

github-actions bot commented Aug 14, 2025

Warnings
⚠️
	The **target branch** for this Pull Request **must be the default branch** of the project (`master`).

	If you would like to add this feature to a different branch, please state this in the PR description and we will consider it.

👋 Hello TheSciBoy, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.

This GitHub project is public mirror of our internal git repository

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved, we synchronize it into our internal git repository.
4. In the internal git repository we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
5. If the change is approved and passes the tests it is merged into the default branch.
5. On next sync from the internal git repository merged change will appear in this public GitHub repository.

Generated by 🚫 dangerJS against d611dd9

@github-actions github-actions bot changed the title feat(tls): Support runtime ATECC608A I2C address configuration in TLS feat(tls): Support runtime ATECC608A I2C address configuration in TLS (IDFGH-16280) Aug 14, 2025
@espressif-bot espressif-bot added the Status: Opened Issue is new label Aug 14, 2025
@AdityaHPatwardhan
Copy link
Collaborator

Hi @TheSciBoy,
Thanks for the PR, Yes, this is indeed helpful. I think one more addition would be to allow dynamically configurable key slot id as well.
We are discussing currently as to how to progress ahead. ( Either to refactor the config to allow more options, or go with the way presented in this PR).
We will take this up soon and update you accordingly.

@TheSciBoy
Copy link
Author

TheSciBoy commented Aug 25, 2025

Hi @TheSciBoy, Thanks for the PR, Yes, this is indeed helpful. I think one more addition would be to allow dynamically configurable key slot id as well. We are discussing currently as to how to progress ahead. ( Either to refactor the config to allow more options, or go with the way presented in this PR). We will take this up soon and update you accordingly.

Sounds good! I have been busy with other things since I posted the PR and have not had time to dig into the details of contributing yet (such as the CLA), which is why the PR remains in draft. But if you maybe want to refactor this completely, then I will not continue with the PR until you have a decision.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Opened Issue is new
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants