Skip to content

Conversation

BLKDASH
Copy link
Contributor

@BLKDASH BLKDASH commented Aug 7, 2025

gap_event_handler used wrong macro; correct check: #ifdef CONFIG_EXAMPLE_SET_RAW_ADV_DATA

Description

The gap_event_handler function used an incorrectly confused macro definition, and the correct macro definition judgment should be #ifdef CONFIG_EXAMPLE_SET_RAW_ADV_DATA
This error causes users to be unable to enable gap broadcasting when enabling "Use raw data for advertising packets and scan response data" in "Example 'GATT SERVER' Config" option in menuconfig

Related

Testing

After correcting this macro definition, the ESP32 is able to broadcast and connect normally using raw packets

Checklist

Before submitting a Pull Request, please ensure the following:

  • [✓] 🚨 This PR does not introduce breaking changes.
  • [✓] All CI checks (GH Actions) pass.
  • [✓] Documentation is updated as needed.
  • [✓] Tests are updated or added as necessary.
  • [✓] Code is well-commented, especially in complex areas.
  • [✓] Git history is clean — commits are squashed to the minimum necessary.

gap_event_handler used wrong macro; correct check: #ifdef CONFIG_EXAMPLE_SET_RAW_ADV_DATA
Copy link

github-actions bot commented Aug 7, 2025

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello BLKDASH, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.

This GitHub project is public mirror of our internal git repository

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved, we synchronize it into our internal git repository.
4. In the internal git repository we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
5. If the change is approved and passes the tests it is merged into the default branch.
5. On next sync from the internal git repository merged change will appear in this public GitHub repository.

Generated by 🚫 dangerJS against e980765

@github-actions github-actions bot changed the title fix(gatt_demo): Fix the problem of macro definition error fix(gatt_demo): Fix the problem of macro definition error (IDFGH-16208) Aug 7, 2025
@espressif-bot espressif-bot added the Status: Opened Issue is new label Aug 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: Opened Issue is new

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants