Skip to content

Conversation

remenyo
Copy link
Contributor

@remenyo remenyo commented Jul 29, 2025

Description

The gpio_reset_pin function attempts to enable internal pullup on input only pins as well, which do not have configurable internal pullups.

For example, in the case of ESP32,

gpio_reset_pin(GPIO_NUM_39);

emits:

E (4535) gpio: gpio_pullup_en(78): GPIO number error (input-only pad has no internal PU)

This change adds the same guard inside gpio_reset_pin before calling gpio_pullup_en that makes gpio_pullup_en print the error in case of calling it with an input only pin.

I'm not familiar with the inside structure of IDF, maybe this is done by purpose, or if not, maybe other parts of the driver should be updated as well. Or maybe the error in gpio_pullup_en should be just a warning.

This change only makes the error log not to show up - the functional effect of calling gpio_reset_pin with any parameter remains identical.

Checklist

  • 🚨 This PR does not introduce breaking changes.
  • All CI checks (GH Actions) pass.
  • Documentation is updated as needed.
  • Tests are updated or added as necessary.
  • Code is well-commented, especially in complex areas.
  • Git history is clean — commits are squashed to the minimum necessary.

The `gpio_reset_pin` function attempted to enable internal pullup on pins which does not have one. This change adds a guard to `gpio_reset_pin` for calling `gpio_pullup_en` - the same guard that makes `gpio_pullup_en` print the error.
@CLAassistant
Copy link

CLAassistant commented Jul 29, 2025

CLA assistant check
All committers have signed the CLA.

Copy link

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "Avoid error message when calling reset on an input only pin.":
    • body's lines must not be longer than 100 characters
    • summary should not end with a period (full stop)
    • summary looks empty
    • type/action looks empty

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

👋 Hello remenyo, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.

This GitHub project is public mirror of our internal git repository

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved, we synchronize it into our internal git repository.
4. In the internal git repository we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
5. If the change is approved and passes the tests it is merged into the default branch.
5. On next sync from the internal git repository merged change will appear in this public GitHub repository.

Generated by 🚫 dangerJS against 19e5a33

@github-actions github-actions bot changed the title change(esp32): Calling gpio_reset_pin on an input only pin should not produce an error message. change(esp32): Calling gpio_reset_pin on an input only pin should not produce an error message. (IDFGH-16106) Jul 29, 2025
@espressif-bot espressif-bot added the Status: Opened Issue is new label Jul 29, 2025
@songruo songruo added the PR-Sync-Merge Pull request sync as merge commit label Aug 1, 2025
@songruo
Copy link
Collaborator

songruo commented Aug 1, 2025

sha=19e5a33b4bd62ebe4c693504a3a0199890be39ef

@espressif-bot espressif-bot added Status: In Progress Work is in progress Status: Done Issue is done internally Resolution: NA Issue resolution is unavailable Resolution: Done Issue is done internally and removed Status: Opened Issue is new Status: In Progress Work is in progress Resolution: NA Issue resolution is unavailable labels Aug 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Sync-Merge Pull request sync as merge commit Resolution: Done Issue is done internally Status: Done Issue is done internally
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants