change(esp32): Calling gpio_reset_pin on an input only pin should not produce an error message. (IDFGH-16106) #17047
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
gpio_reset_pin
function attempts to enable internal pullup on input only pins as well, which do not have configurable internal pullups.For example, in the case of ESP32,
emits:
This change adds the same guard inside
gpio_reset_pin
before callinggpio_pullup_en
that makesgpio_pullup_en
print the error in case of calling it with an input only pin.I'm not familiar with the inside structure of IDF, maybe this is done by purpose, or if not, maybe other parts of the driver should be updated as well. Or maybe the error in gpio_pullup_en should be just a warning.
This change only makes the error log not to show up - the functional effect of calling
gpio_reset_pin
with any parameter remains identical.Checklist