[deep_sleep] Update possible modes for esp32_ext1_wakeup #5391
Conversation
✅ Deploy Preview for esphome ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Warning Rate limit exceeded@swoboda1337 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 9 minutes and 15 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
WalkthroughUpdated documentation for ESP32 EXT1 deep sleep wakeup modes: added the ANY_LOW option and expanded/clarified descriptions for ALL_LOW and ANY_HIGH, including device-specific notes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Suggested reviewers
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
content/components/deep_sleep.md (1)
71-72: Minor copyedit: keep wording consistent (“is LOW/HIGH” vs “go/goes”).Use consistent phrasing across the three modes (e.g., “is LOW/HIGH”) to avoid mixed grammar.
If you prefer to keep the single‑line style, this minimal tweak works:
- - **mode** (**Required**): The mode to use for the wakeup source. Must be one of `ANY_LOW` (wake up when any - pin goes LOW), `ALL_LOW` (wake up when all pins go LOW) or `ANY_HIGH` (wake up when any pin goes HIGH). + - **mode** (**Required**): The mode to use for the wakeup source. Must be one of `ANY_LOW` (wake up when any pin is LOW), `ALL_LOW` (wake up when all pins are LOW), or `ANY_HIGH` (wake up when any pin is HIGH).
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
content/components/deep_sleep.md(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
**
⚙️ CodeRabbit configuration file
- Do not generate or add any sequence diagrams
Files:
content/components/deep_sleep.md
tomasvanpottelbergh
changed the title
* Update deep_sleep.md * Clarify modes per variant * Clean up --------- Co-authored-by: Jonathan Swoboda <[email protected]>
* Update deep_sleep.md * Clarify modes per variant * Clean up --------- Co-authored-by: Jonathan Swoboda <[email protected]>
2 participants
Description:
Add missing
ANY_LOWoption foresp32_ext1_wakeupmodes in deep sleep module. See https://github.com/esphome/esphome/blob/dev/esphome/components/deep_sleep/__init__.py#L158C1-L162C2.Checklist:
I am merging into
nextbecause this is new documentation that has a matching pull-request in esphome as linked above.or
I am merging into
currentbecause this is a fix, change and/or adjustment in the current documentation and is not for a new component or feature.Link added in
/components/index.rstwhen creating new documents for new components or cookbook.New Component Images
If you are adding a new component to ESPHome, you can automatically generate a standardized black and white component name image for the documentation.