--fq-rate doesn't work for --reverse tests

[bmah888]

Context

• Version of iperf3: 3.16

• Hardware: x86_64 bare-metal, Mellanox ConnectX-5

• Operating system (and distribution, if any): Ubuntu Linux 20.04

• Other relevant information (for example, non-default compilers,
  libraries, cross-compiling, etc.):

Bug Report

• Expected Behavior

--fq-rate should rate-limit --reverse connections

• Actual Behavior

--fq-rate seems to have no effect on --reverse tests

• Steps to Reproduce

• Possible Solution

[bmah888]

Connecting to host 192.168.127.2, port 5201
[  5] local 192.168.128.2 port 39334 connected to 192.168.127.2 port 5201
[ ID] Interval           Transfer     Bitrate         Retr  Cwnd
[  5]   0.00-1.00   sec  1.75 MBytes  14.7 Mbits/sec    0    122 KBytes       
[  5]   1.00-2.00   sec   896 KBytes  7.34 Mbits/sec    0    122 KBytes       
[  5]   2.00-3.00   sec   896 KBytes  7.34 Mbits/sec    0    122 KBytes       
[  5]   3.00-4.00   sec   896 KBytes  7.34 Mbits/sec    0    122 KBytes       
[  5]   4.00-5.00   sec  1.25 MBytes  10.5 Mbits/sec    0    122 KBytes       
[  5]   5.00-6.00   sec   896 KBytes  7.34 Mbits/sec    0    122 KBytes       
[  5]   6.00-7.00   sec   896 KBytes  7.34 Mbits/sec    0    122 KBytes       
[  5]   7.00-8.00   sec   896 KBytes  7.34 Mbits/sec    0    122 KBytes       
[  5]   8.00-9.00   sec  1.00 MBytes  8.39 Mbits/sec    0    122 KBytes       
[  5]   9.00-10.00  sec   896 KBytes  7.34 Mbits/sec    0    122 KBytes       
- - - - - - - - - - - - - - - - - - - - - - - - -
[ ID] Interval           Transfer     Bitrate         Retr
[  5]   0.00-10.00  sec  10.1 MBytes  8.49 Mbits/sec    0             sender
[  5]   0.00-10.00  sec  9.50 MBytes  7.97 Mbits/sec                  receiver

iperf Done.
swlarsen@netlab-pt8:~/git/esnet/iperf$ ~/git/esnet/iperf/src/iperf3 -c 192.168.127.2 --fq-rate 8M -R
Connecting to host 192.168.127.2, port 5201
Reverse mode, remote host 192.168.127.2 is sending
[  5] local 192.168.128.2 port 57462 connected to 192.168.127.2 port 5201
[ ID] Interval           Transfer     Bitrate
[  5]   0.00-1.00   sec  2.79 GBytes  23.9 Gbits/sec                  
[  5]   1.00-2.00   sec  2.83 GBytes  24.3 Gbits/sec                  
[  5]   2.00-3.00   sec  2.27 GBytes  19.5 Gbits/sec                  
[  5]   3.00-4.00   sec  2.11 GBytes  18.1 Gbits/sec                  
[  5]   4.00-5.00   sec  2.02 GBytes  17.4 Gbits/sec                  
[  5]   5.00-6.00   sec  2.04 GBytes  17.6 Gbits/sec                  
[  5]   6.00-7.00   sec  2.04 GBytes  17.6 Gbits/sec                  
[  5]   7.00-8.00   sec  2.03 GBytes  17.4 Gbits/sec                  
[  5]   8.00-9.00   sec  2.02 GBytes  17.3 Gbits/sec                  
[  5]   9.00-10.00  sec  2.00 GBytes  17.2 Gbits/sec                  
- - - - - - - - - - - - - - - - - - - - - - - - -
[ ID] Interval           Transfer     Bitrate         Retr
[  5]   0.00-10.00  sec  22.2 GBytes  19.0 Gbits/sec    0             sender
[  5]   0.00-10.00  sec  22.2 GBytes  19.0 Gbits/sec                  receiver

iperf Done.
swlarsen@netlab-pt8:~/git/esnet/iperf$ ~/git/esnet/iperf/src/iperf3 -c 192.168.127.2 --bitrate 8M -R
Connecting to host 192.168.127.2, port 5201
Reverse mode, remote host 192.168.127.2 is sending
[  5] local 192.168.128.2 port 33730 connected to 192.168.127.2 port 5201
[ ID] Interval           Transfer     Bitrate
[  5]   0.00-1.00   sec  1.00 MBytes  8.38 Mbits/sec                  
[  5]   1.00-2.00   sec  1.00 MBytes  8.39 Mbits/sec                  
[  5]   2.00-3.00   sec   896 KBytes  7.34 Mbits/sec                  
[  5]   3.00-4.00   sec  1.00 MBytes  8.39 Mbits/sec                  
[  5]   4.00-5.00   sec  1.00 MBytes  8.39 Mbits/sec                  
[  5]   5.00-6.00   sec   896 KBytes  7.34 Mbits/sec                  
[  5]   6.00-7.00   sec  1.00 MBytes  8.39 Mbits/sec                  
[  5]   7.00-8.00   sec  1.00 MBytes  8.39 Mbits/sec                  
[  5]   8.00-9.00   sec   896 KBytes  7.34 Mbits/sec                  
[  5]   9.00-10.00  sec  1.00 MBytes  8.39 Mbits/sec                  
- - - - - - - - - - - - - - - - - - - - - - - - -
[ ID] Interval           Transfer     Bitrate         Retr
[  5]   0.00-10.00  sec  9.62 MBytes  8.07 Mbits/sec    0             sender
[  5]   0.00-10.00  sec  9.62 MBytes  8.07 Mbits/sec                  receiver

iperf Done.
swlarsen@netlab-pt8:~/git/esnet/iperf$ ~/git/esnet/iperf/src/iperf3 -c 192.168.127.2 --bitrate 8M 
Connecting to host 192.168.127.2, port 5201
[  5] local 192.168.128.2 port 59626 connected to 192.168.127.2 port 5201
[ ID] Interval           Transfer     Bitrate         Retr  Cwnd
[  5]   0.00-1.00   sec  1.00 MBytes  8.39 Mbits/sec    0    411 KBytes       
[  5]   1.00-2.00   sec  1.00 MBytes  8.39 Mbits/sec    0    411 KBytes       
[  5]   2.00-3.00   sec   896 KBytes  7.34 Mbits/sec    0    411 KBytes       
[  5]   3.00-4.00   sec  1.00 MBytes  8.39 Mbits/sec    0    411 KBytes       
[  5]   4.00-5.00   sec  1.00 MBytes  8.39 Mbits/sec    0    411 KBytes       
[  5]   5.00-6.00   sec   896 KBytes  7.34 Mbits/sec    0    411 KBytes       
[  5]   6.00-7.00   sec  1.00 MBytes  8.39 Mbits/sec    0    411 KBytes       
[  5]   7.00-8.00   sec  1.00 MBytes  8.39 Mbits/sec    0    411 KBytes       
[  5]   8.00-9.00   sec   896 KBytes  7.34 Mbits/sec    0    411 KBytes       
[  5]   9.00-10.00  sec  1.00 MBytes  8.39 Mbits/sec    0    411 KBytes       
- - - - - - - - - - - - - - - - - - - - - - - - -
[ ID] Interval           Transfer     Bitrate         Retr
[  5]   0.00-10.00  sec  9.62 MBytes  8.07 Mbits/sec    0             sender
[  5]   0.00-10.00  sec  9.62 MBytes  8.07 Mbits/sec                  receiver

iperf Done.

[swlars]

Fixed in TCP-only. UDP still unresolved.