Skip to content

fix: wrong location reporting in require-alt-text #574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 2, 2025
Merged

fix: wrong location reporting in require-alt-text #574

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/rules/require-alt-text.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ export default {
},

html(node) {
const text = stripHtmlComments(node.value);
const text = stripHtmlComments(sourceCode.getText(node));
Copy link
Member

@mdjermanovic mdjermanovic Nov 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, html#value doesn't have leading spaces of lines, and that causes this problem.


/** @type {RegExpExecArray} */
let match;
Expand Down
36 changes: 36 additions & 0 deletions tests/rules/require-alt-text.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,6 +257,42 @@ ruleTester.run("require-alt-text", rule, {
},
],
},
{
code: '<img\n src="image.png" />',
errors: [
{
messageId: "altTextRequired",
line: 1,
column: 1,
endLine: 2,
endColumn: 20,
},
],
},
{
code: '<img\n src="image.png" />',
errors: [
{
messageId: "altTextRequired",
line: 1,
column: 1,
endLine: 2,
endColumn: 21,
},
],
},
{
code: '<img\n src="image.png" />',
errors: [
{
messageId: "altTextRequired",
line: 1,
column: 1,
endLine: 2,
endColumn: 22,
},
],
},
{
code: dedent`
<!-- <img src="image.png" /> -->
Expand Down