feat: add no-bare-urls rule #418
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nzakas
reviewed
Jun 12, 2025
lumirlumir
requested changes
Jun 13, 2025
nzakas
previously approved these changes
Jun 16, 2025
Member
nzakas
left a comment
nzakas
left a comment
There was a problem hiding this comment.
LGTM. Would like @lumirlumir to review before merging.
Member
|
ping @lumirlumir |
Member
|
I've left two comments for unresolved reviews: Once we decide on the approach, I'll take a look at the final version of this rule. (I think there's still room for improvement, considering the discussions.) |
lumirlumir
requested changes
Jun 18, 2025
lumirlumir
requested changes
Jun 19, 2025
lumirlumir
approved these changes
Jun 20, 2025
Member
lumirlumir
left a comment
lumirlumir
left a comment
There was a problem hiding this comment.
LGTM, Thanks!
Would like @nzakas to verify the changes before merging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
This PR implements the
no-bare-urlsrule to enforce proper URL formatting in Markdown documents. The rule ensures URLs are either wrapped in angle brackets (autolinks) or used with text (links), rather than being used as bare URLs.What changes did you make? (Give an overview)
Implemented the
no-bare-urlsrule, along with documentation and tests.Related Issues
Fixes #399
Is there anything you'd like reviewers to focus on?