Skip to content

Conversation

@Pixel998
Copy link
Contributor

@Pixel998 Pixel998 commented Jun 9, 2025

Prerequisites checklist

What is the purpose of this pull request?

To add JSON frontmatter support using the VitePress-style format (--- delimiters)

What changes did you make? (Give an overview)

  • Added JSON frontmatter parser configuration using --- delimiters
  • Added tests
  • Added types

Related Issues

Closes #404

Is there anything you'd like reviewers to focus on?

@lumirlumir lumirlumir moved this to Needs Triage in Triage Jun 10, 2025
@lumirlumir lumirlumir moved this from Needs Triage to Implementing in Triage Jun 10, 2025
Copy link
Member

@lumirlumir lumirlumir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Nice work!

Would like another review before merging, since it's a feature.

@lumirlumir lumirlumir moved this from Implementing to Second Review Needed in Triage Jun 10, 2025
Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@nzakas nzakas merged commit 8b77e69 into eslint:main Jun 10, 2025
23 checks passed
@github-project-automation github-project-automation bot moved this from Second Review Needed to Complete in Triage Jun 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Complete

Development

Successfully merging this pull request may close these issues.

Change Request: Add JSON Frontmatter Support

4 participants