Bug: [new config system] globs are ignoring dot files

[mdjermanovic]

Environment

Node version: v16.14.0
npm version: v8.3.1
Local ESLint version: v8.23.0 (Currently used)
Global ESLint version: Not found
Operating System: win32 10.0.19044

What parser are you using?

Default (Espree)

What did you do?

// eslint.config.js

module.exports = [];

// .foo.js

npx eslint *.js -f tap

What did you expect to happen?

Per the RFC, this should include .foo.js?

1. Defaults - by default, ESLint will ignore node_modules and .git directories only. This is different from the current behavior where ESLint ignores node_modules and all files/directories beginning with a dot (.).

In that case, I would expect this output:

TAP version 13
1..2
ok 1 - D:\tmp\tmp\.foo.js
ok 2 - D:\tmp\tmp\eslint.config.js

What actually happened?

The .foo.js file was not linted:

TAP version 13
1..1
ok 1 - D:\tmp\tmp\eslint.config.js

Participation

• I am willing to submit a pull request for this issue.

Additional comments

No response

[nzakas]

Confirmed, this is a bug. We should be picking up dot files by default now.

[nzakas]

Because this example has a glob without quotes, that means the shell is expanding it and is therefore not including dot files. I don't think there's anything we can do about that.

However, I also see that quoting the glob pattern does not pick up dot files. That is a bug per the RFC:

npx eslint "*.js" -f tap

This may end up being a case where we should mirror the shell expansion to avoid confusion?

[mdjermanovic]

Because this example has a glob without quotes, that means the shell is expanding it and is therefore not including dot files.

Oh, I was running this in a windows shell and it passed *.js to eslint (I double-checked process.argv). I'll use quotes from now on to avoid ambiguity.

This may end up being a case where we should mirror the shell expansion to avoid confusion?

That would mean that dotfiles are effectively ignored by default?

[mdjermanovic]

I prepared #16269 to include dotfiles in glob and directory searches (per the RFC), if we decide that should be the behavior.

[nzakas]

This may end up being a case where we should mirror the shell expansion to avoid confusion?
That would mean that dotfiles are effectively ignored by default?

Yeah, that's what I'm wondering. We obviously have control over what gets passed to globby, but, as in your example, it was unclear if the pattern was being passed directly to globby or if it was a shell expansion. I'm just wondering if it would make sense to keep the current behavior because then we at least know the result will be the same regardless of shell expansion or not?

[mdjermanovic]

By the current behavior, do you mean current FlatESLint behavior or current eslintrc behavior?