Skip to content

Conversation

@teor292
Copy link
Contributor

@teor292 teor292 commented Sep 17, 2019

Hi. I needed to compile Simd on Visual studio 2019 and I have got some problems.

  1. There are no sln and project file for VS2019. So, I copy it from VS2017w and update.
  2. It doesn't compile: unknown _MM_K0_REG identifier, so I change if def.
  3. There was a test error on ConditionalCount16i >=
    Here screen: https://ibb.co/HHysQnb
    I have done some test and I think that it is a VS2019 compiler bug. It is related to function overload and optimization, because it exist only in Release version (x64, not tested on x32) and after renaming two functions (GreaterOrEqual16i to GreaterOrEqual16i_m256 and GreaterOrEqual16i_m128) the tests was passed. So, I made a commit with such changes.

@ermig1979 ermig1979 merged commit b8c6a8b into ermig1979:master Sep 18, 2019
@ermig1979
Copy link
Owner

It's a good job!
Minor notes: PlatformToolset property is better to be modified in Prop.props file (unfortunately it is have to make manually in XML file).

@teor292
Copy link
Contributor Author

teor292 commented Sep 18, 2019

Thanks.
Ок, I didn't know that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants