Skip to content

Add back deprecated runners with warning #348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2025

Conversation

paulo-ferraz-oliveira
Copy link
Collaborator

Description

This broke for some consumers, but if we state (as a code warning, and by not having it in the README.md) that support is limited, this might not only nudge consumers in the right direction but also "support" those that want to work with deprecated elements.

@paulo-ferraz-oliveira
Copy link
Collaborator Author

Done for #332 (comment). @petermm, feel free to continue here, especially if you can provide feedback on results (I can't test this on GHA, since ubuntu-20.04 is actually not usable).

@petermm
Copy link

petermm commented Jun 24, 2025

awesome!
just one blocker: Error: core.warn is not a function

it's core.warning https://github.com/actions/toolkit/tree/main/packages/core#logging

have CI run(s) ready: https://github.com/petermm/AtomVM/actions/runs/15862621970/job/44723112273

but no hurry.

thanks!

@paulo-ferraz-oliveira paulo-ferraz-oliveira force-pushed the fix/deprecated-with-warning branch from 4001d63 to 00b756c Compare June 24, 2025 22:48
@paulo-ferraz-oliveira
Copy link
Collaborator Author

I've pushed a fix.

@paulo-ferraz-oliveira paulo-ferraz-oliveira force-pushed the fix/deprecated-with-warning branch from 00b756c to d3a6a2a Compare June 24, 2025 23:04
@paulo-ferraz-oliveira
Copy link
Collaborator Author

I've pushed a fix.

@paulo-ferraz-oliveira paulo-ferraz-oliveira marked this pull request as ready for review June 24, 2025 23:05
@paulo-ferraz-oliveira
Copy link
Collaborator Author

Given the limited change scope, if tests pass per @petermm's feedback, I'm merging, to cut 0.20.1.

Copy link

@petermm petermm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@paulo-ferraz-oliveira paulo-ferraz-oliveira merged commit a8bc27e into main Jun 24, 2025
73 checks passed
@paulo-ferraz-oliveira paulo-ferraz-oliveira deleted the fix/deprecated-with-warning branch June 24, 2025 23:13
@paulo-ferraz-oliveira
Copy link
Collaborator Author

This was released in v1.20.1.

@petermm
Copy link

petermm commented Jun 24, 2025

Thank you for accommodating this obscure usage of old OS/compilers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants