-
Notifications
You must be signed in to change notification settings - Fork 64
Add back deprecated runners with warning #348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
8726067 to
4001d63
Compare
|
Done for #332 (comment). @petermm, feel free to continue here, especially if you can provide feedback on results (I can't test this on GHA, since |
|
awesome! it's have CI run(s) ready: https://github.com/petermm/AtomVM/actions/runs/15862621970/job/44723112273 but no hurry. thanks! |
4001d63 to
00b756c
Compare
|
I've pushed a fix. |
00b756c to
d3a6a2a
Compare
|
I've pushed a fix. |
|
Given the limited change scope, if tests pass per @petermm's feedback, I'm merging, to cut |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's green and works now: https://github.com/petermm/AtomVM/actions/runs/15862621970/job/44725251953#step:8:27
|
This was released in v1.20.1. |
|
Thank you for accommodating this obscure usage of old OS/compilers! |
Description
This broke for some consumers, but if we state (as a code warning, and by not having it in the
README.md) that support is limited, this might not only nudge consumers in the right direction but also "support" those that want to work with deprecated elements.