Minor maintenance updates #336
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We also: 1. simplify format 2. simplify eslint 3. make yamllint use eslint plugin (it wasn't flagging issues properly) 4. rename jslint as eslint 5. introduce lodash 6. make for a more modern approach to js/eslint
1. more breathing room for the reader 2. more information for the consumer
Not all of them, some I'll deal with later...
paulo-ferraz-oliveira
requested review from
starbelly and
wojtekmach
and removed request for
starbelly
wojtekmach
approved these changes
May 29, 2025
|
Yeah, |
|
This was released in v1.20.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I build on the experience from #333 to tweak some stuff. Commits tell the story via comments.
We:
take care of some security issues issued by GitHub
update our dependencies' versions to as latest as possible
fix an issue with
yamllintwhere the files weren't actually lintedadapt to a more modern JS/
eslintapproachmake
action.ymlmore explicit withrequired: true/falsewhere appropriateadd
actionlintto the list of action linters (and act on its results)act on lint results for more recent software versions
I have read and understood the contributing guidelines