New compiler hardening options break C++ exception propagation #10084
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvakvs
added
team:PS
CT Test Results 2 files 17 suites 4m 21s ⏱️ Results for commit 5510216. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
kvakvs
force-pushed
the
eimytdl/otp28-wx-crashes/OTP-19724
branch
from
baa5be4 to
a54264d
Compare
dgud
reviewed
Aug 11, 2025
kvakvs
removed
the
testing
kvakvs
force-pushed
the
eimytdl/otp28-wx-crashes/OTP-19724
branch
from
a54264d to
54fcf6b
Compare
kvakvs
force-pushed
the
eimytdl/otp28-wx-crashes/OTP-19724
branch
from
54fcf6b to
5510216
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9972
The PR disables one compiler hardening option when compiling wx C++ wrapper code, and only on MacOS (darwin).
The hardening options were set to on by default in OTP 28 and having them enabled breaks C++ exception propagation, making exceptions fall through into the C abort function which ends the VM.