Catches references to self when not using macros. #392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous code would only catch references to self when using the OCMStub/OCMExpect macros. Now we avoid self referential retain loops if you use the `[[[foo stub] andReturn:foo] sharedInstance]` API.
erikdoe
reviewed
Mar 26, 2020
| { | ||
| [[self stub] addInvocationAction:[[[OCMNonRetainingObjectReturnValueProvider alloc] initWithValue:mockObject] autorelease]]; | ||
| return self; | ||
| return self; |
There was a problem hiding this comment.
I am going to merge this PR as is. In future, though, please don't make whitespace changes. I know that inconsistencies have crept in over the years, but cleaning them up like this adds noise to the real change. Thanks.
|
i would like to revert this change. this has caused a regression in a long-standing test that we've had that performs a how would you feel about me submitting a pull-request to revert this? i will be glad to further test any follow-up changes. cc @erikdoe @dmaclach ? |
This was referenced Apr 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous code would only catch references to self when using the OCMStub/OCMExpect macros.
Now we avoid self referential retain loops if you use the
[[[foo stub] andReturn:foo] sharedInstance]API.