Skip to content

Conversation

@taratorio
Copy link
Member

closes https://github.com/erigontech/security/issues/54

fixes:

@yperbasis yperbasis requested a review from canepat October 20, 2025 11:45
@taratorio taratorio enabled auto-merge (squash) October 20, 2025 11:47
@taratorio
Copy link
Member Author

reminder to self: cherry-pick to release/3.2 after merge

@yperbasis yperbasis requested a review from Copilot October 21, 2025 07:54
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the eth_config RPC endpoint implementation to comply with the latest specification. The changes address several edge cases and specification requirements around fork configuration and blob schedules.

Key changes:

  • Uses current block time instead of wall clock time for fork determination
  • Returns blobSchedule: null for pre-Cancun forks instead of erroring
  • Handles genesis block edge case where activation time should be 0

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

File Description
rpc/jsonrpc/eth_system.go Updated Config method to use block time, removed pre-Cancun error, handle genesis case, changed BlobSchedule to nullable
rpc/jsonrpc/eth_system_test.go Added test cases for genesis and pre-Cancun scenarios, updated test structure to support head state
execution/chain/chain_config.go Changed GetBlobConfig to return nil for pre-Cancun, added nil checks in dependent methods
rpc/jsonrpc/testdata/eth_config/*.json Added test fixtures for new scenarios

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@taratorio taratorio merged commit e1b05a8 into main Oct 21, 2025
17 checks passed
@taratorio taratorio deleted the eth_config_sherlock branch October 21, 2025 09:32
taratorio added a commit that referenced this pull request Oct 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants