Skip to content

fix chaintip mode in stage_exec #17482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix chaintip mode in stage_exec #17482

wants to merge 2 commits into from

Conversation

@sudeepdino008
Copy link
Member

@sudeepdino008 sudeepdino008 commented Oct 15, 2025 •
edited
Loading

  • fix: handle block limit error in chaintip mode
  • commit tx after each block exec (actually what happens at chaintip today)
  • when chainTipMode = true, newSync sets noCommit=false; so case chainTipMode && noCommit doesn't need to be handled.

@sudeepdino008 sudeepdino008 requested review from AskAlexSharov and mh0lt and removed request for AskAlexSharov October 15, 2025 11:49
AskAlexSharov
AskAlexSharov reviewed Oct 16, 2025
View reviewed changes
@sudeepdino008 sudeepdino008 enabled auto-merge (squash) October 20, 2025 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AskAlexSharov AskAlexSharov AskAlexSharov left review comments

@mh0lt mh0lt Awaiting requested review from mh0lt

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sudeepdino008 @AskAlexSharov