Skip to content

Conversation

@somnathb1
Copy link
Contributor

@somnathb1 somnathb1 commented Oct 3, 2024

Rather than creating a trie and then using the trie root, use the hash of the rlp encoding of the requests list.

Ref1 - ethereum/EIPs#8854 ,
Ref2 - ethereum/EIPs#8907,
Ref3 - ethereum/EIPs#8924

(Tasks board - #12106)

@somnathb1
Copy link
Contributor Author

While Ref1 here does say return keccak256(rlp.encode([rlp.encode(req) for req in list])) - I interpret the rlp encoding inside the loop as simply, the rlp encoding of the byte string that is req, and not the un-flattened rlp encoding we used have earlier.

@somnathb1 somnathb1 added the do-not-merge PR that is in a merge-able state but is waiting for something else to take place before merging label Oct 3, 2024
@somnathb1 somnathb1 marked this pull request as draft October 11, 2024 06:47
@somnathb1 somnathb1 changed the title Update EIP-7685 requests root to flat hash Flatten EIP-7685 requests, and requests_root Oct 11, 2024
@somnathb1
Copy link
Contributor Author

Closing in favour of #12337

@somnathb1 somnathb1 closed this Oct 16, 2024
@somnathb1 somnathb1 deleted the pectra4_5 branch November 5, 2024 14:03
@VBulikov VBulikov mentioned this pull request Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge PR that is in a merge-able state but is waiting for something else to take place before merging Pectra

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants