Implement method in BoundingBox to create corresponding Mesh #239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to a corresponding Mesh object.
Strepto
reviewed
Sep 9, 2024
| /// Creates a Mesh <see cref="Mesh"/> representing the bounding box coordinates. | ||
| /// </summary> | ||
| /// <returns>Mesh representing the bounding box.</returns> | ||
| public Mesh ToBoxMesh(float error) |
There was a problem hiding this comment.
Why do we need a mesh instead of just creating a Box primitive?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will implement BoundingBox::ToMesh() and a corresponding test. It can be used to convert a mesh into a bounding box mesh by first calling Mesh::CalculateAxisAlignedBoundingBox() and then calling ToMesh() on the resulting bounding box.