Use data_get to retrieve value from resource #154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using Laravel's `data_get` helper allows nested values to be used for the dependencies, which is important for packages like Nova Page Manager where all the fields are stored in a `data` JSON column (that is casted into an array in the model). This allows dependencies on field attributes such as `data->type`. This PR does not introduce any breaking changes and does not affect existing setups.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using Laravel's
data_gethelper allows nested values to be used for the dependencies, which is important for packages like Nova Page Manager where all the fields are stored in adataJSON column (that is casted into an array in the model). This allows dependencies on field attributes such asdata->type. This PR does not introduce any breaking changes and does not affect existing setups.