#5481 - Ambiguous CHEM shown wrong at Sequence mode #8273
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When loading ambiguous CHEM monomers from HELM notation (e.g.,
CHEM1{(A:10+C:50)}$$V2.0) in Sequence mode, the symbol was incorrectly displayed as%instead of@.Before:
After:
Root Cause
The
AmbiguousSequenceItemRendererwas always displaying the monomer'slabelproperty, which defaults to%for all ambiguous monomers. However, when an ambiguous monomer contains different monomer types, it is classified asCHEM(viaAmbiguousMonomer.getMonomerClass()), and should display the same symbol as regular CHEM monomers:@.Solution
Modified
AmbiguousSequenceItemRenderer.tsto check the monomer's classification:This ensures symbol consistency across all monomer types in Sequence mode:
@@✓ (fixed)%Testing
Fixes #4556
Original prompt
Fixes #5481
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.