Skip to content

7083 Delete operation on Sequence mode causes hanging bonds and undeletable monomers #7166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open

7083 Delete operation on Sequence mode causes hanging bonds and undeletable monomers #7166

wants to merge 19 commits into from

Conversation

KristinaKasyanovskaya
Copy link
Collaborator

How the feature works? / How did you fix the issue?

(Screenshots, videos, or GIFs, if applicable)

Check list

  • unit-tests written
  • e2e-tests written
  • documentation updated
  • PR name follows the pattern #1234 – issue name
  • branch name doesn't contain '#'
  • PR is linked with the issue
  • base branch (master or release/xx) is correct
  • task status changed to "Code review"
  • reviewers are notified about the pull request

@KristinaKasyanovskaya KristinaKasyanovskaya linked an issue May 28, 2025 that may be closed by this pull request
Delete operation on Sequence mode causes hanging bonds and undeletable monomers #7083
Open
KristinaKasyanovskaya and others added 17 commits May 29, 2025 00:08
@KristinaKasyanovskaya
fix: fix code
c36d888
@KristinaKasyanovskaya
fix: prevent bond creation when only one adjacent node exists
aabf11b
@KristinaKasyanovskaya
fix(sequence): properly remove ribose when deleting backbone
40b8d41
@KristinaKasyanovskaya
fix: move logic in separate method
dfeeaf6
@KristinaKasyanovskaya
fix: fix backspace method
43c7d96
@KristinaKasyanovskaya
fix: fix delete method in keyboard events
0ec0a75
@KristinaKasyanovskaya
fix: fix orphanPhosphate method
9b3e4ae
@KristinaKasyanovskaya
fix: fix orphanPhosphate method
5ea21b2
@KristinaKasyanovskaya
Revert "fix: fix orphanPhosphate method"
9a32746
@KristinaKasyanovskaya
fix: fix logic to handle delete method
b44d20d
@KristinaKasyanovskaya
fix: fix logic to handle delete method
021eac4
@KristinaKasyanovskaya
Merge remote-tracking branch 'origin' into 7083-delete-operation-on-s…
f4bc0fa 
…equence-mode-causes-hanging-bonds-and-undeletable-monomers
@KristinaKasyanovskaya
fix: fix sequence mode
874f87b
@KristinaKasyanovskaya
feat: add delete operation
54edf5b
@KristinaKasyanovskaya
fix(sequence): handle edge-case deletions for antisense monomers
3870ea9
@KristinaKasyanovskaya
removed an extra check in the code
50678b4
@KukushkinDmi1riy
#7083 Delete operation on Sequence mode causes hanging bonds and unde…
a392a62 
…letable monomers
@KukushkinDmi1riy KukushkinDmi1riy changed the title Draft 7083 Delete operation on Sequence mode causes hanging bonds and undeletable monomers 7083 Delete operation on Sequence mode causes hanging bonds and undeletable monomers Jul 21, 2025
@KukushkinDmi1riy KukushkinDmi1riy self-assigned this Jul 21, 2025
@KristinaKasyanovskaya KristinaKasyanovskaya marked this pull request as ready for review July 21, 2025 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NataliaLoginova NataliaLoginova Awaiting requested review from NataliaLoginova

@rrodionov91 rrodionov91 Awaiting requested review from rrodionov91

@Zhirnoff Zhirnoff Awaiting requested review from Zhirnoff

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Delete operation on Sequence mode causes hanging bonds and undeletable monomers
2 participants
@KristinaKasyanovskaya @KukushkinDmi1riy