Skip to content

Conversation

siarhei-epam
Copy link
Collaborator

@siarhei-epam siarhei-epam commented Aug 1, 2025

Description:

This PR addresses issues with modal abort handling, specifically fixing the incorrect order of abort() calls when pressing ESC and improving the overall modal abort logic to ensure proper handling of active modals.

Fixed:

  • Modal Abort Logic: Fixed incorrect order of abort() calls when pressing ESC key, ensuring proper modal cleanup sequence
  • Modal Context: Improved modal abort handling logic to prevent race conditions and ensure correct handling of active modals
  • Nested Modals: Enhanced support for nested modal scenarios with proper abort behavior

Added:

  • Comprehensive nested modals example demonstrating proper abort behavior
  • Enhanced test coverage for modal abort scenarios
  • New icons and assets for improved user experience

Changed:

  • Modal abort sequence now follows proper cleanup order
  • Enhanced modal state management for better reliability
  • Updated modal documentation with new examples and best practices

Packages Updated:

  • @epam/uui-components: Modal overlay improvements
  • @epam/uui-core: Modal context service enhancements
  • @epam/uui: Modal component updates and testing improvements

Issue link:

#2873

QA notes:

@siarhei-epam siarhei-epam self-assigned this Aug 1, 2025
Copy link

github-actions bot commented Aug 1, 2025

Generated by: track-bundle-size
Generated at: Mon, 18 Aug 2025 15:12:45 GMT
Bundle size diff (in kBytes). Not gzipped. Both CSS & JS included.
Baseline: v6.1.5-beta.1 (2025-07-15)
CI Status: ok

Module Baseline Size
(v6.1.5-beta.1)
Size Diff Within
Threshold
Threshold
(min - max)
templateApp 646.65 662.87 +16.22
js:+6.96
css:+9.26
🆗 581.98 - 711.31
@epam/app 5368.95 5540.46 +171.5
js:+163.5
css:+8.01
🆗 4832.06 - 5905.85
@epam/electric 5.03 5.04 +0.01
js:+0.01
css:0
🆗 4.53 - 5.54
@epam/promo 55.43 55.61 +0.19
js:+0.01
css:+0.18
🆗 49.89 - 60.97
@epam/uui-extra 0.21 0.21 0
js:0
css:0
🆗 0.19 - 0.23
@epam/loveship 92.62 92.8 +0.19
js:+0.01
css:+0.17
🆗 83.35 - 101.88
@epam/uui-components 251.75 250.96 -0.79
js:-0.82
css:+0.03
🆗 226.58 - 276.93
@epam/uui-core 325.46 326.45 +0.98
js:+0.98
css:0
🆗 292.92 - 358.01
@epam/uui-db 41.63 41.63 0
js:0
css:0
🆗 37.47 - 45.8
@epam/uui-docs 179.06 181.02 +1.96
js:+1.96
css:0
🆗 161.15 - 196.96
@epam/uui-editor 173.82 173.87 +0.06
js:+0.03
css:+0.02
🆗 156.44 - 191.2
@epam/uui-timeline 75.5 75.5 +0
js:+0
css:+0
🆗 67.95 - 83.04
@epam/uui 503.4 517.92 +14.51
js:+9.11
css:+5.41
🆗 453.06 - 553.74
new sizes (raw)

To set the sizes as a new baseline, you can copy/paste next content to the uui-build/config/bundleSizeBaseLine.json and commit the file.

{
  "version": "6.2.0",
  "timestamp": "2025-08-18",
  "sizes": {
    "templateApp": {
      "css": 242414,
      "js": 436365
    },
    "@epam/app": {
      "css": 703996,
      "js": 4969430
    },
    "@epam/electric": {
      "css": 2275,
      "js": 2886
    },
    "@epam/promo": {
      "css": 47803,
      "js": 9148
    },
    "@epam/uui-extra": {
      "css": 0,
      "js": 213
    },
    "@epam/loveship": {
      "css": 55372,
      "js": 39658
    },
    "@epam/uui-components": {
      "css": 23250,
      "js": 233733
    },
    "@epam/uui-core": {
      "css": 0,
      "js": 334280
    },
    "@epam/uui-db": {
      "css": 0,
      "js": 42633
    },
    "@epam/uui-docs": {
      "css": 2154,
      "js": 183211
    },
    "@epam/uui-editor": {
      "css": 12936,
      "js": 165114
    },
    "@epam/uui-timeline": {
      "css": 2202,
      "js": 75109
    },
    "@epam/uui": {
      "css": 197484,
      "js": 332858
    }
  }
}

Generated by: generate-components-api
CI Status: ok

Total amount of exported types/props without JSDoc comments

Amount
Types 337 (+0) 🆗
Props 221 (+0) 🆗

@siarhei-epam siarhei-epam changed the title [Modals]: fixed incorrect order of abort() calls when pressing ESC Fix: Improve Modal Abort Logic for Correct Handling of Active Modals Aug 13, 2025
@AlekseyManetov AlekseyManetov merged commit 42dfa8f into develop Aug 19, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants