-
Notifications
You must be signed in to change notification settings - Fork 76
[A11y]: clickable elements inside controls are not available from keyboard #2845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Generated by: track-bundle-size
new sizes (raw)To set the sizes as a new baseline, you can copy/paste next content to the {
"version": "6.2.0",
"timestamp": "2025-09-03",
"sizes": {
"templateApp": {
"css": 243818,
"js": 436363
},
"@epam/app": {
"css": 705419,
"js": 4969417
},
"@epam/electric": {
"css": 2275,
"js": 2886
},
"@epam/promo": {
"css": 47803,
"js": 9148
},
"@epam/uui-extra": {
"css": 0,
"js": 213
},
"@epam/loveship": {
"css": 55372,
"js": 39660
},
"@epam/uui-components": {
"css": 23273,
"js": 233715
},
"@epam/uui-core": {
"css": 0,
"js": 334310
},
"@epam/uui-db": {
"css": 0,
"js": 42633
},
"@epam/uui-docs": {
"css": 2154,
"js": 183211
},
"@epam/uui-editor": {
"css": 12936,
"js": 165114
},
"@epam/uui-timeline": {
"css": 2202,
"js": 75109
},
"@epam/uui": {
"css": 199075,
"js": 333119
}
}
} Generated by: generate-components-api Total amount of exported types/props without JSDoc comments
|
Currently, when focus is set to the clear buttons via keyboard, their color doesn't change like it would on hover or click. Let me know if it should be changed. |
As far as I understand, the best practice would be also adding a live region, which would announce the clear button's appearance/disappearance (with a combination of the input's state), for screen reader users. I started to implement this, but the possible combination of cases looks too much for the case. For example, a simple use case with an initially empty text input:
If implementing of such a component is necessary, please let me know. But it will be necessary to decide, how to properly define its API and placement. |
changelog.md
Outdated
**What's Fixed** | ||
* [PickerModal]: fixed `disableClear: true` behavior for `selectionMode: multi`, added `Clear` button functionality to `selectionMode: single` | ||
* [PickerInput] Stop "Escape" key press event propagation when body is opened ([#2839](https://github.com/epam/UUI/pull/2839)) | ||
* Make clear buttons accessible via keyboards ([#2845](https://github.com/epam/UUI/pull/2845)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should all the affected components be listed here?
…focused in `TextInput` component
…oggler` components
Description
IconButton
-s. The following components are affected:selectionMode="multiple"
)ref
to the input instead of its container in inputs (except Picker Input) (potential breaking change).-clickable
marker now, because the buttons do (potential breaking change)align-items: center
to center the clear button (otherwise its height matches the wrapper's height, which makes the focus outline unpleasantly "tall")aria-label
attribute's value for clear button to "Clear input" to match the one inTextInput
TextInput
componentnull
value insetupTextInput
Issue link
#2719
QA notes