extproc: hotfix for gzip header #683
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexa Griffith <[email protected]>
Co-authored-by: Sukumar Gaonkar <[email protected]> Signed-off-by: Alexa Griffith <[email protected]>
mathetake
added a commit
that referenced
this pull request
Jun 5, 2025
**Commit Message** Clearing content-type header is only necessary when the response mutation is actually happening. Otherwise, say when the original response is in gzip and not mutation is happening, the client gets gzip and no content-encoding header. **Related Issues/PRs (if applicable)** Follow up on #683 --------- Signed-off-by: Takeshi Yoneda <[email protected]> Co-authored-by: Erica Hughberg <[email protected]>
cmaddalozzo
pushed a commit
to cmaddalozzo/ai-gateway
that referenced
this pull request
Jun 11, 2025
**Commit Message** This is a hotfix for a bug where if the gzip header is present, we decompress and leave the header. This results in the client throwing an error trying to decompress based on the header, but it has already been decompressed. This hot fix removes the header. In the future we probably want to return it compressed with the header intact. for example - the error I encountered was ```io.netty.handler.codec.compression.DecompressionException: Input is not in the GZIP format``` Co-authored-by: Sukumar Gaonkar <[email protected]> --------- Signed-off-by: Alexa Griffith <[email protected]> Co-authored-by: Sukumar Gaonkar <[email protected]>
cmaddalozzo
pushed a commit
to cmaddalozzo/ai-gateway
that referenced
this pull request
Jun 11, 2025
…#685) **Commit Message** Clearing content-type header is only necessary when the response mutation is actually happening. Otherwise, say when the original response is in gzip and not mutation is happening, the client gets gzip and no content-encoding header. **Related Issues/PRs (if applicable)** Follow up on envoyproxy#683 --------- Signed-off-by: Takeshi Yoneda <[email protected]> Co-authored-by: Erica Hughberg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message
This is a hotfix for a bug where if the gzip header is present, we decompress and leave the header. This results in the client throwing an error trying to decompress based on the header, but it has already been decompressed. This hot fix removes the header. In the future we probably want to return it compressed with the header intact.
for example - the error I encountered was
io.netty.handler.codec.compression.DecompressionException: Input is not in the GZIP formatCo-authored-by: Sukumar Gaonkar [email protected]