Skip to content

Conversation

corranwebster
Copy link
Contributor

This is a more natural user interaction, and allows the selection tool to co-exist with other tools (eg. PanTool2) in a nicer fashion.

@cfarrow
Copy link

cfarrow commented Jun 10, 2014

I agree with the change, but I think it should be done in a backwards-compatible way. This change will cause all subclasses of SelectTool that overload normal_left_down to react on mouse down and mouse up. I recommend adding a flag that allows one to modify the selection behavior, and which defaults to the left-down behavior.

@itziakos
Copy link
Member

I would also like to note that activating the Tool at mouse_up without marking the position of the mouse_down can cause unexpected behaviour since the mouse_down -> mouse_up can take place far apart from each other.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants