Skip to content

Use foreign memory arena for big bindings cache #13872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 32 commits into
base: develop
Choose a base branch
from
+561 −17
Draft

Use foreign memory arena for big bindings cache #13872

Changes from 1 commit
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
06ae858
Test that second cache serialization fails
Akirathan Aug 27, 2025
ab0fc5e
Cache uses native memory Arena
Akirathan Aug 27, 2025
883dc14
Add optional CacheStatistics to EnsoContext
Akirathan Aug 28, 2025
963afda
Use logName instead of entryName
Akirathan Aug 28, 2025
5a14330
Test save of suggestions and bindings caches
Akirathan Aug 28, 2025
24b7c4d
Use hamcrest matchers
Akirathan Aug 28, 2025
58b92e8
Add test for loading caches
Akirathan Aug 28, 2025
822bf5d
Rename test
Akirathan Aug 28, 2025
e3a1c36
Test that loading bindings cache of big project should be mmapped
Akirathan Aug 28, 2025
54deef1
refact: extract method
Akirathan Aug 28, 2025
cef3885
Test that cache can be saved.
Akirathan Aug 28, 2025
04eaf57
Test global cache save preference
Akirathan Aug 28, 2025
225beaa
More cache tests
Akirathan Aug 28, 2025
3e362b8
Use only primitive bytes
Akirathan Aug 28, 2025
f63d3a3
Revert "Use logName instead of entryName"
Akirathan Aug 29, 2025
be04961
Revert "Add optional CacheStatistics to EnsoContext"
Akirathan Aug 29, 2025
ae1d687
Test caches by collecting logs
Akirathan Aug 29, 2025
4f01c2c
CachedData test class is an empty class.
Akirathan Aug 29, 2025
5bce4bc
Add memory arena validity assert
Akirathan Aug 29, 2025
46b42e5
First close memory arena and then writeBytesTo
Akirathan Aug 29, 2025
8653350
Memory arena must be shared.
Akirathan Sep 1, 2025
2756b69
Cache.invalidate closes memory arena
Akirathan Sep 1, 2025
7cf44a9
Test that memory arena is closed after cache is saved
Akirathan Sep 1, 2025
a38623a
Test that byteBuffer from deserialization is read only
Akirathan Sep 1, 2025
74a9fc6
readability is tested via ByteBuffer.get
Akirathan Sep 1, 2025
e79df91
Random is not static field
Akirathan Sep 1, 2025
79ecc3c
Test that byteBuffer is closed after cache is invalidated
Akirathan Sep 1, 2025
00e3786
randomBytes is not static method
Akirathan Sep 1, 2025
b1bd76a
fmt
Akirathan Sep 1, 2025
c7cbcac
Add `-H:+ForeignAPISupport` NI flag
Akirathan Sep 1, 2025
72478c0
New Arena is created before mmap.
Akirathan Sep 3, 2025
1de26ec
Merge branch 'develop' into wip/akirathan/13816-bindings-via-arena
Akirathan Sep 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...e/runner/src/main/resources/META-INF/native-image/org/enso/runner/native-image.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
Args=--features=org.enso.runner.EnsoLibraryFeature
Args = --features=org.enso.runner.EnsoLibraryFeature \
-H:+ForeignAPISupport
Loading