-
Notifications
You must be signed in to change notification settings - Fork 334
Avoid the need for -H:+ForeignAPISupport
#13230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✨ GUI Checks ResultsSummary
See individual check results for more details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we potentially detect the unsupported platform and leave the old support, if we feel that it looks/is less complex? It certainly feels less hacky than using ByteBuffers.
And when GraalVM 25.x lands, we could easily go back to the previous implementation.
|
Things seem to work on Mac Arm now: passes. |
|
+H:ForeignAPISupport-H:+ForeignAPISupport
Pull Request Description
Modifies #13206 to not need
+H:ForeignAPISupportby alternatively usingUnmanagedMemoryandByteBufferon each side of theChannel.Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,