Persistable.Pool to group related instances into pool
#13201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaroslavTulach
added
the
CI: No changelog needed
2 tasks
✨ GUI Checks ResultsSummary
See individual check results for more details. |
hubertp
approved these changes
May 30, 2025
Akirathan
approved these changes
May 30, 2025
This was referenced May 30, 2025
mergify bot
pushed a commit
that referenced
this pull request
May 30, 2025
The usage of `--enable-preview` is causing problems when switching between frgaal and javac. JDK's compiler only allows `--enable-preview` with the latest `--target` e.g. `24`. This affects also other JDK utilities like `javadoc`. As a result I was unable to use `persistance/doc` to generate Javadoc when working on #13201. The only reason why we are using`--enable-preview` is **usage of `_` in `switch` statements**. It is not really convincing reason for requiring preview mode. Hence this PR removes `--enable-preview` setting from `build.sbt` and changes the affected code to give the variable another name than `_`. # Important Notes The best solution would be for frgaal to `--enable-preview` by default (at the end the language is controlled by version of the frgaal compiler, no need for another switch) or offer some other (JDK javac unknown) option `-Denable.preview=true` to enable preview or offer an option to _disable preview_. That way it would be easier to switch between frgaal and latest JDK's `javadoc` without changing the arguments for the compilation. That's however a discussion to be held elsewhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Having multiple pools of
Persistableinstances was always needed and will be needed even more to address #13172.Docs & Checklist
Java,