Skip to content

WIP: Implement h2 protocol #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

WIP: Implement h2 protocol #214

wants to merge 4 commits into from

Conversation

songww
Copy link
Contributor

@songww songww commented Oct 6, 2018

#47

Something to be fixed:

  1. Too much code is duplicated with H11's implementation.
  2. ssl.SSLError: [SSL: KRB5_S_INIT] application data after close notify. This error occurred with hypercorn too.
  3. connection: upgrade support. to websocket and h11 to h2(https auto upgrade to h2 is supported).
  4. logger
  5. tests

It works.

songww added 4 commits October 6, 2018 00:36
@songww
Add ssl support.
c48a2bf
@songww
Implement base h2 protocol.
9507a09
@songww
Fix ERR_SPDY_INADEQUATE_TRANSPORT_SECURITY
fe546ea
@songww
1. Fixed `ssl.SSLError: [SSL: KRB5_S_INIT] application data after clo…
35d951f 
…se notify`.

1. Support HTTP/1.1 upgrade to HTTP/2 without TLS.

Bug:
  1. If post request with body, push_promise wait for body too.
@songww songww closed this Oct 17, 2018
@lovelydinosaur
Copy link
Collaborator

Thanks so much for your work on this, sorry I’ve not been able to review yet. Any particular reason for the close?

@songww
Copy link
Contributor Author

songww commented Oct 20, 2018

There are still many problems, but I don't have time to continue on it.

@lovelydinosaur
Copy link
Collaborator

Gotcha. Thanks for submitting all the same. Will get onto http/2 support in time, so this’ll be really helpful when we get there.

@ahopkins
Copy link

I'm one of the developers on sanic. Adding HTTP2 has been on the radar for sanic for a while.

@tomchristie submitted this PR to add an ASGI interface. Thanks Tom!

Just curious what the plan is for uvicorn and what the current hurdles are to get http2 implemented.

@lovelydinosaur
Copy link
Collaborator

@ahopkins - There's no significant technical hurdles, just time.

The Hypercorn and Daphne ASGI servers already supports HTTP/2, so we have alternative implementations. Presumably we'll add one for Uvicorn based on a similar implementation.

@ahopkins
Copy link

@tomchristie Got it. Thanks. 👍

Might I suggest:

from time import more

more.make(hours=6)

@Vibhu-Agarwal Vibhu-Agarwal mentioned this pull request Apr 30, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@songww @lovelydinosaur @ahopkins