-
-
Notifications
You must be signed in to change notification settings - Fork 1k
Fix environment proxies #2741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
lovelydinosaur
merged 8 commits into
encode:master
from
karpetrosyan:fix-environment-proxies
Dec 14, 2023
Merged
Fix environment proxies #2741
lovelydinosaur
merged 8 commits into
encode:master
from
karpetrosyan:fix-environment-proxies
Dec 14, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e27fee0 to
fc9952f
Compare
Contributor
Author
|
Also, our documentation is now incorrect; according to https://www.python-httpx.org/environment_variables/#no_proxy, we can use scheme filtering with the NO_PROXY environment variable, which we cannot. |
Contributor
Author
|
Docs |
lovelydinosaur
approved these changes
Dec 14, 2023
Contributor
|
Excellent, yep. Apologies for the delay. Let's get a CHANGELOG entry and pull this in. 👍 (Maybe this?... "Handle |
Contributor
Author
|
Done! |
Merged
samclearman
pushed a commit
to titanmsp/httpx
that referenced
this pull request
Apr 26, 2025
* Add red test * Make the test pass * Lint * chanelog --------- Co-authored-by: Karen Petrosyan <[email protected]> Co-authored-by: Tom Christie <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the httpx parses
NO_PROXY: http://google.comto{'all://*http://google.com': None}but expected{'http://google.com': None}TODO