Improve 'RemoteProtocolError' message on early server disconnects. #479
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…disconnects without sending a response
lovelydinosaur
deleted the
more-helpful-exception-on-server-disconnect
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revisit #313 - looks like this behaviour got lost in the 0.14 redesign.
Currently if the server is in a listening state, then disconnects without sending a response, then users will see the following error...
Which really isn't informative as an end-user. We probably would prefer to special case this particular transition as a
ConnectError. It's not quite the same as a networkConnectError, since it occurs in cases where the connection was already established and hanging around, but is closed once it an incoming request is sent.