[dylink] Fix addEmJs when parameter is indirect pointer #25740
Conversation
eagleoflqj
force-pushed
the
dylink
branch
2 times, most recently
from
bf6c07d to
c113518
Compare
kripken
left a comment
kripken
left a comment
There was a problem hiding this comment.
Thanks! This looks right.
I believe the test for it is other.test_em_js_side_module, runnable with
./test/runner other.test_em_js_side_module
Please add a ** pointer there, to test this.
sbc100
changed the title
| js_side_func(42, "hello"); | ||
| js_side_func2("hello again"); | ||
| js_side_func_void(); | ||
| js_side_func_indirect_ptr(NULL); |
There was a problem hiding this comment.
Can you pass &"hello" and then print the string js_side_func_indirect_ptr?
otherwise lgtm
There was a problem hiding this comment.
Code inside EM_JS is JavaScript function so I cannot dereference pointer in the C way. Is there a way to do it with JS?
There was a problem hiding this comment.
Yes you can use the makeGetValue macro. See the libraries in src/lib for examples
|
Also see the failing test, an expectation needs to be updated. See instructions for that in the CI error. |
I think just rebase should fix that |
3 participants
I'm in the middle of porting libskk with glib, and encountered a
SyntaxError: Unexpected token '*'.Given the value of
cSig,jsArgandjsArgsin debugger view, it seems straightforward.