Update ctor eval debug output test expectation #21729
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the expected output of `test_eval_ctors_debug_output` to account for changed debug output due to WebAssembly/binaryen#6464. The test will now succeed before and after that upstream Binaryen change.
Member
Author
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
kripken
approved these changes
Apr 9, 2024
Member
|
(the title should maybe be "allow changes to roll in" as opposed to "update test expectation" as this does the former and I assume a later PR will do the latter?) |
sbc100
approved these changes
Apr 9, 2024
Member
Author
|
oh wait this is not the fix I meant to push |
Member
Author
|
Thanks for the catch, @kripken. The description and title were correct and the code now matches them. |
impact-maker
pushed a commit
to impact-maker/emscripten
that referenced
this pull request
Apr 11, 2024
Update the expected output of `test_eval_ctors_debug_output` to account for changed debug output due to WebAssembly/binaryen#6464. The test will now succeed before and after that upstream Binaryen change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the expected output of
test_eval_ctors_debug_outputto account forchanged debug output due to WebAssembly/binaryen#6464.
The test will now succeed before and after that upstream Binaryen change.