Skip to content

Conversation

@quantizor
Copy link
Contributor

@quantizor quantizor commented Aug 20, 2017

I think this makes slightly more sense than just linking to root. The visitor can always back up if they want to.

This might also be a good time to start thinking about individual package READMEs. The NPM pages are a little bare without them: https://www.npmjs.com/package/react-emotion

I think this makes slightly more sense than just linking to root. The
user can always back up if they want to.
@codecov-io
Copy link

codecov-io commented Aug 20, 2017

Codecov Report

Merging #276 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #276   +/-   ##
=======================================
  Coverage   90.37%   90.37%           
=======================================
  Files          21       21           
  Lines         966      966           
  Branches      260      260           
=======================================
  Hits          873      873           
  Misses         75       75           
  Partials       18       18

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12bf1b8...2c5abd4. Read the comment docs.

Copy link
Member

@emmatown emmatown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure but I think this could break the links to Issues and PRs on npm.

@quantizor
Copy link
Contributor Author

I'm not sure about pulls, but I think issues uses a different property: https://github.com/tkh44/emotion/pull/276/files#diff-54043be09c6d011d84adfabf6e46686aR34

@tkh44
Copy link
Member

tkh44 commented Aug 20, 2017

If we are removing the git reference we should just use this format:

https://github.com/babel/babel/blob/7.0/packages/babel-plugin-transform-decorators/package.json#L7

@tkh44 tkh44 merged commit 6a919bf into emotion-js:master Aug 22, 2017
@tkh44
Copy link
Member

tkh44 commented Aug 22, 2017

Thanks!

@quantizor quantizor deleted the es-fix-repo-links branch August 22, 2017 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants