Skip to content

Fix babel plugin crashing when called programmatically without providing a filename #1574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 26, 2019
Merged

Fix babel plugin crashing when called programmatically without providing a filename #1574

merged 1 commit into from
Oct 26, 2019

Conversation

@Andarist
Copy link
Member

@Andarist Andarist commented Oct 26, 2019

fixes #1439

@changeset-bot
Copy link

changeset-bot bot commented Oct 26, 2019

🦋 Changeset is good to go

Latest commit: e7c45ef

We got this.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Andarist Andarist mentioned this pull request Oct 26, 2019
Closed
@codecov
Copy link

codecov bot commented Oct 26, 2019 •
edited
Loading

Codecov Report

Merging #1574 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted Files Coverage Δ
scripts/old-babel-tester/src/index.js 100% <ø> (ø) ⬆️
...ages/babel-plugin-emotion/src/utils/source-maps.js 100% <100%> (ø) ⬆️
...-plugin-emotion/src/utils/get-target-class-name.js 100% <100%> (ø) ⬆️

emmatown
emmatown approved these changes Oct 26, 2019
View reviewed changes
Copy link
Member

@emmatown emmatown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@emmatown emmatown merged commit b3a0f14 into master Oct 26, 2019
@emmatown emmatown deleted the fix/babel-plugin-no-fs branch October 26, 2019 20:35
@github-actions github-actions bot mentioned this pull request Oct 26, 2019
Merged
louisgv pushed a commit to louisgv/emotion that referenced this pull request Sep 6, 2020
@Andarist @emmatown
Fix babel plugin crashing when called programmatically without provid…
9cdd50b 
…ing a filename (emotion-js#1574)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emmatown emmatown emmatown approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

issue when using @emotion/styled with babel programmatic

3 participants

@Andarist @emmatown