Port the sizes workflow from glimmer-vm #20883
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kategengler
requested changes
Mar 24, 2025
kategengler
reviewed
Mar 24, 2025
kategengler
requested changes
Mar 24, 2025
kategengler
reviewed
Mar 25, 2025
kategengler
approved these changes
Mar 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example from glimmer-vm: glimmerjs/glimmer-vm#1690 (comment)
We should probably ship a prod build of ember (even if we don't have ember-cli / vite consumers use it), because its a good indicator of the impact of terser settings.
This PR does not do anything with prod builds as ember-source currently does not have one and relies on the app to correctly configure that stuff.
The sizes action is a good indicator of growth / regression / shrinkage for all the modules, and allows us to hopefully prevent situations like what happened during the 5.6 VM upgrade.